From: Andrea Arcangeli <andrea@suse.de>
To: Andrew Morton <akpm@osdl.org>
Cc: linux-kernel@vger.kernel.org, hugh@veritas.com
Subject: Re: mapped pages being truncated [was Re: 2.6.5-rc2-aa5]
Date: Tue, 30 Mar 2004 20:51:29 +0200 [thread overview]
Message-ID: <20040330185129.GC3808@dualathlon.random> (raw)
In-Reply-To: <20040330102834.7627cf54.akpm@osdl.org>
On Tue, Mar 30, 2004 at 10:28:34AM -0800, Andrew Morton wrote:
> Andrea Arcangeli <andrea@suse.de> wrote:
> >
> > here we go, my new debugging WARN_ON in in __remove_from_page_cache
> > triggered just before the other one in page_remove_rmap, as I expected
> > it was truncate removing pages from pagecache before all mappings were
> > dropped:
>
> XFS is doing peculiar things - xfs_setattr calls truncate_inode_pages()
> before running vmtruncate().
>
> xfs_setattr
> ->xfs_itruncate_start
> ->VOP_TOSS_PAGES
> ->fs_tosspages
> ->truncate_inode_pages
Ok, so objrmap needs my WARN_ON changes to survive the above. I believe
I can close the bug as fixed now (however I will leave the WARN_ON in
the code).
Still xfs seems pretty broken doing the above.
next prev parent reply other threads:[~2004-03-30 18:53 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-03-29 15:06 2.6.5-rc2-aa5 Andrea Arcangeli
2004-03-29 20:48 ` 2.6.5-rc2-aa5 Andrew Morton
2004-03-29 22:45 ` 2.6.5-rc2-aa5 Andrea Arcangeli
2004-03-30 16:10 ` mapped pages being truncated [was Re: 2.6.5-rc2-aa5] Andrea Arcangeli
2004-03-30 18:01 ` Hugh Dickins
2004-03-30 18:20 ` Andrea Arcangeli
2004-03-30 18:48 ` Hugh Dickins
2004-03-30 19:01 ` Andrea Arcangeli
2004-03-30 19:06 ` Hugh Dickins
2004-03-30 19:12 ` Andrea Arcangeli
2004-03-30 18:28 ` Andrew Morton
2004-03-30 18:51 ` Andrea Arcangeli [this message]
2004-03-30 20:13 ` Nathan Scott
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040330185129.GC3808@dualathlon.random \
--to=andrea@suse.de \
--cc=akpm@osdl.org \
--cc=hugh@veritas.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox