Re: Unregistering interfaces

Greg KH
2004-03-30T23:32:05Z

On Tue, Mar 30, 2004 at 03:16:37PM -0800, Andrew Morton wrote:
> Greg KH <greg@kroah.com> wrote:
> >
> > On Tue, Mar 30, 2004 at 11:21:35AM +0530, Maneesh Soni wrote:
> > >
> > > I am not very clear about how the first two behave. Still I can think
> > > of a solution within sysfs like this as Alen suggested. But again I am not
> > > very sure if this can be done properly without any races. But anyway I am
> > > trying.
> > >
> > > 1) backout my patch sysfs-pin-kobject.patch
> >
> > I think we need to do this now, as it is not a correct fix, and causes
> > more problems than good at this time.
>
> But the patch was correct. sysfs retains a pointer to the kobject, it
> should take a ref on it?

Yes, but it was taking references for files that are not present in
sysfs. That's not good :)

> > I suggest you try to fix the oops
> > you were seeing in either another way, or in a way that does not break
> > other things :)
>
> Didn't we demonstrate that the code which broke was already broken? And
> that it has other problems regardless of the kobject pinning fix, such as the
> userpace-holding-a-file-open-wedges-khubd problem?

No. We fixed the wedge-khubd issue. That was my fault for allowing
that change to go in the first place. Sorry about that.

Let me run some tests with Maneesh's patch pulled out to see if that
solves the oopses I can generate...

> Worried that this is all heading in the wrong direction...

I'm worried about that too.

thanks,

greg k-h