From: David Gibson <david@gibson.dropbear.id.au>
To: Linus Torvalds <torvalds@osdl.org>, Andrew Morton <akpm@osdl.org>
Cc: linux-kernel@vger.kernel.org, linuxppc64-dev@lists.linuxppc.org
Subject: Add useful warning message in PPC64 hugepage code
Date: Thu, 1 Apr 2004 14:49:24 +1000 [thread overview]
Message-ID: <20040401044924.GC13436@zax> (raw)
Linus, please apply:
This patch adds a debugging message to the ppc64 hugepage code when we
attempt to open the "low" (32-bit) hugepage window on PPC64, but can't
because a (non-hugepage) mapping already exists in the region.
Index: working-2.6/arch/ppc64/mm/hugetlbpage.c
===================================================================
--- working-2.6.orig/arch/ppc64/mm/hugetlbpage.c 2004-04-01 14:28:49.000000000 +1000
+++ working-2.6/arch/ppc64/mm/hugetlbpage.c 2004-04-01 14:32:30.430607144 +1000
@@ -253,8 +253,11 @@
/* Check no VMAs are in the region */
vma = find_vma(mm, TASK_HPAGE_BASE_32);
- if (vma && (vma->vm_start < TASK_HPAGE_END_32))
+ if (vma && (vma->vm_start < TASK_HPAGE_END_32)) {
+ printk(KERN_DEBUG "Low HTLB region busy: PID=%d vma @ %lx-%lx\n",
+ current->pid, vma->vm_start, vma->vm_end);
return -EBUSY;
+ }
/* Clean up any leftover PTE pages in the region */
spin_lock(&mm->page_table_lock);
--
David Gibson | For every complex problem there is a
david AT gibson.dropbear.id.au | solution which is simple, neat and
| wrong.
http://www.ozlabs.org/people/dgibson
reply other threads:[~2004-04-01 4:51 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040401044924.GC13436@zax \
--to=david@gibson.dropbear.id.au \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc64-dev@lists.linuxppc.org \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox