From: Andrew Morton <akpm@osdl.org>
To: Olof Johansson <olof@austin.ibm.com>
Cc: manfred@colorfullife.com, torvalds@osdl.org,
linux-kernel@vger.kernel.org, anton@samba.org
Subject: Re: Oops in get_boot_pages at reboot
Date: Thu, 1 Apr 2004 10:55:53 -0800 [thread overview]
Message-ID: <20040401105553.38468a64.akpm@osdl.org> (raw)
In-Reply-To: <Pine.A41.4.44.0403312015050.29064-100000@forte.austin.ibm.com>
Olof Johansson <olof@austin.ibm.com> wrote:
>
> So __pollwait() calls __get_free_page(), system_running is 0 so
> get_boot_pages is called. Since get_boot_pages is labeled __init, badness
> happens.
>
> How about checking against mem_init_done instead of system_running? It
> helps against the oops, but there might be some good reason not to do
> it. I don't claim to know the intrisic details about the MM. :-)
Do we really need to clear system_running at reboot? I'd always viewed it
as "everything is initialised and usable", and that's generally true at
reboot time.
next prev parent reply other threads:[~2004-04-01 18:57 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-04-01 16:56 Oops in get_boot_pages at reboot Olof Johansson
2004-04-01 17:11 ` Manfred Spraul
2004-04-01 17:32 ` Olof Johansson
2004-04-01 18:55 ` Andrew Morton [this message]
2004-04-02 1:26 ` Olof Johansson
2004-04-02 1:44 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040401105553.38468a64.akpm@osdl.org \
--to=akpm@osdl.org \
--cc=anton@samba.org \
--cc=linux-kernel@vger.kernel.org \
--cc=manfred@colorfullife.com \
--cc=olof@austin.ibm.com \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox