From: William Lee Irwin III <wli@holomorphy.com>
To: linux-kernel@vger.kernel.org, akpm@osdl.org
Subject: Re: fix get_wchan() FIXME wrt. order of functions
Date: Thu, 1 Apr 2004 03:35:32 -0800 [thread overview]
Message-ID: <20040401113532.GC791@holomorphy.com> (raw)
In-Reply-To: <20040401095526.GB791@holomorphy.com>
On Thu, Apr 01, 2004 at 01:55:26AM -0800, William Lee Irwin III wrote:
> This addresses the issue with get_wchan() that the various functions
> acting as scheduling-related primitives are not, in fact, contiguous
> in the text segment. It creates an ELF section for scheduling primitives
> to be placed in, and places currently-detected (i.e. skipped during stack
> decoding) scheduling primitives and others like io_schedule() and down(),
> which are currently missed by get_wchan() code, into this section also.
> The net effects are more reliability of get_wchan()'s results and the
> new ability, made use of by this code, to arbitrarily place scheduling
> primitives in the source code without disturbing get_wchan()'s accuracy.
> Suggestions by Arnd Bergmann and Matthew Wilcox regarding reducing the
> invasiveness of the patch were incorporated during prior rounds of review.
> I've at least tried to sweep all arches in this patch.
> vs. 2.6.5-rc3. Rediffing vs. -mm would be easy for me.
Brown paper bag patch. Should fix the missing relocations you saw.
Index: sched-2.6.5-rc3/arch/i386/kernel/semaphore.c
===================================================================
--- sched-2.6.5-rc3.orig/arch/i386/kernel/semaphore.c 2004-03-31 18:34:02.000000000 -0800
+++ sched-2.6.5-rc3/arch/i386/kernel/semaphore.c 2004-04-01 03:13:48.000000000 -0800
@@ -188,7 +188,7 @@
* value..
*/
asm(
-".section sched.text\n"
+".section .sched.text\n"
".align 4\n"
".globl __down_failed\n"
"__down_failed:\n\t"
prev parent reply other threads:[~2004-04-01 11:35 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-04-01 9:55 fix get_wchan() FIXME wrt. order of functions William Lee Irwin III
2004-04-01 11:35 ` William Lee Irwin III [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040401113532.GC791@holomorphy.com \
--to=wli@holomorphy.com \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox