From: Paul Jackson <pj@sgi.com>
To: William Lee Irwin III <wli@holomorphy.com>
Cc: akpm@osdl.org, linux-kernel@vger.kernel.org
Subject: Re: remove bitmap_shift_*() bitmap length limits
Date: Thu, 1 Apr 2004 13:30:33 -0800 [thread overview]
Message-ID: <20040401133033.435a3857.pj@sgi.com> (raw)
In-Reply-To: <20040330081142.GL791@holomorphy.com>
> The primary effect of the patch is to remove the MAX_BITMAP_BITS
I'm all in favor of that, and this appears one of the two
reasonable alternatives to accomplish that.
The other, perhaps, would be a single bit loop, but one
that went directly into the destination buffer.
That would be slower, smaller and easier to see by
inspection that it was probably right.
This bitmap shift routines receive limited use at present.
Offhand, I see only one use -- a bitmap_shift_right() in
bitmap_scnprintf(), and a few physids_shift macros, that
are in turn themselves unused.
This might argue for the slow, stupid, small solution ...
--
I won't rest till it's the best ...
Programmer, Linux Scalability
Paul Jackson <pj@sgi.com> 1.650.933.1373
next prev parent reply other threads:[~2004-04-01 21:33 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-03-30 6:51 remove bitmap_shift_*() bitmap length limits William Lee Irwin III
2004-03-30 7:36 ` William Lee Irwin III
2004-03-30 8:11 ` William Lee Irwin III
2004-04-01 21:30 ` Paul Jackson [this message]
2004-04-01 22:42 ` Paul Jackson
2004-04-04 6:57 ` Paul Jackson
2004-04-04 7:04 ` William Lee Irwin III
2004-04-04 7:17 ` Paul Jackson
2004-04-04 7:11 ` Paul Jackson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040401133033.435a3857.pj@sgi.com \
--to=pj@sgi.com \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=wli@holomorphy.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox