From: Gerd Knorr <kraxel@bytesex.org>
To: Andrew Morton <akpm@osdl.org>,
Kernel List <linux-kernel@vger.kernel.org>
Subject: [patch] v4l: tuner fix
Date: Mon, 5 Apr 2004 13:53:28 +0200 [thread overview]
Message-ID: <20040405115328.GA29527@bytesex.org> (raw)
Hi,
This patch fixes a bug in the tuner descriptions and prepares for the
removal of the type= insmod option by printing a warning when it is
used.
Gerd
diff -up linux-2.6.5/drivers/media/video/tuner.c linux/drivers/media/video/tuner.c
--- linux-2.6.5/drivers/media/video/tuner.c 2004-04-05 10:42:40.510765397 +0200
+++ linux/drivers/media/video/tuner.c 2004-04-05 10:49:57.836295644 +0200
@@ -233,7 +233,7 @@ static struct tunertype tuners[] = {
{ "Philips 1236D ATSC/NTSC daul in",Philips,ATSC,
16*157.25,16*454.00,0xa0,0x90,0x30,0x8e,732},
{ "Philips NTSC MK3 (FM1236MK3 or FM1236/F)", Philips, NTSC,
- 16*160.00,16*442.00,0x01,0x02,0x04,0x8,732},
+ 16*160.00,16*442.00,0x01,0x02,0x04,0x8e,732},
{ "Philips 4 in 1 (ATI TV Wonder Pro/Conexant)", Philips, NTSC,
16*160.00,16*442.00,0x01,0x02,0x04,0x8e,732},
@@ -1050,8 +1050,12 @@ static int tuner_attach(struct i2c_adapt
t->radio_if2 = 10700*1000; // 10.7MHz - FM radio
i2c_attach_client(client);
- if (type < TUNERS)
+ if (type < TUNERS) {
set_type(client, type, "insmod option");
+ printk("tuner: The type=<n> insmod option will go away soon.\n");
+ printk("tuner: Please use the tuner=<n> option provided by\n");
+ printk("tuner: tv card core driver (bttv, saa7134, ...) instead.\n");
+ }
return 0;
}
--
http://bigendian.bytesex.org
reply other threads:[~2004-04-05 12:00 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040405115328.GA29527@bytesex.org \
--to=kraxel@bytesex.org \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox