From: Ben Collins <bcollins@debian.org>
To: Dmitry Torokhov <dtor_core@ameritech.net>
Cc: linux-kernel@vger.kernel.org, Marcel Lanz <marcel.lanz@ds9.ch>
Subject: Re: [PANIC] ohci1394 & copy large files
Date: Mon, 5 Apr 2004 09:44:41 -0400 [thread overview]
Message-ID: <20040405134440.GA13168@phunnypharm.org> (raw)
In-Reply-To: <200404050003.13758.dtor_core@ameritech.net>
On Mon, Apr 05, 2004 at 12:03:10AM -0500, Dmitry Torokhov wrote:
> On Sunday 04 April 2004 09:13 am, Ben Collins wrote:
> > On Sun, Apr 04, 2004 at 04:16:00PM +0200, Marcel Lanz wrote:
> > > Since 2.6.4 and still in 2.6.5 I get regurarly a Kernel panic if I try
> > > to backup large files (10-35GB) to an external attached disc (200GB/JFS) via ieee1394/sbp2.
> > >
> > > Has anyone similar problems ?
> >
> > Known issue, fixed in our repo. I still need to sync with Linus once I
> > iron one more issue and merge some more patches.
> >
>
> I have some concerns that it is completely fixed in your tree - there is still
> a race - if hpsb_packet_received arrives before hosb_packet_sent then there is
> a chance that the code will try to put the same packet in the completion queue
> twice. With SVN tree it will cause kernel BUG in skb code, in BK tree kernel
> will just oops.
>
> I wonder what was the reason to convert the code to abuse skbs aside for using
> skbs queues and their locking?
>
> Anyway, below is a backport of my patch from SVN to BK tree, I would like to
> know if it works for others...
That's the other problem I was talking about. I'm reviewing your patch
today.
--
Debian - http://www.debian.org/
Linux 1394 - http://www.linux1394.org/
Subversion - http://subversion.tigris.org/
WatchGuard - http://www.watchguard.com/
prev parent reply other threads:[~2004-04-05 13:57 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-04-04 14:16 [PANIC] ohci1394 & copy large files Marcel Lanz
2004-04-04 14:13 ` Ben Collins
2004-04-04 23:00 ` Benjamin Herrenschmidt
2004-04-04 23:17 ` Ben Collins
2004-04-04 23:28 ` Randy.Dunlap
2004-04-05 0:09 ` Ben Collins
2004-04-05 0:07 ` Benjamin Herrenschmidt
2004-04-05 0:12 ` Ben Collins
2004-04-05 5:03 ` Dmitry Torokhov
2004-04-05 13:44 ` Ben Collins [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040405134440.GA13168@phunnypharm.org \
--to=bcollins@debian.org \
--cc=dtor_core@ameritech.net \
--cc=linux-kernel@vger.kernel.org \
--cc=marcel.lanz@ds9.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox