public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Stelian Pop <stelian@popies.net>
To: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Cc: davej@codemonkey.org.uk, cpufreq@www.linux.org.uk, linux@brodo.de
Subject: [PATCH 2.6] cpufreq longrun driver fix
Date: Mon, 5 Apr 2004 17:50:12 +0200	[thread overview]
Message-ID: <20040405155012.GI2718@deep-space-9.dsnet> (raw)

Hi,

My TM5600 Crusoe processor, found inside a Sony Vaio C1VE laptop,
does not work with the longrun cpufreq driver.

Upon investigation, the reason is that trying to set the performance 
to 80% in longrun_determine_freqs leaves the performance to 100%.
The performance level, at least on this particular model, can be lowered
only in 33% steps. And in order to put the performance to 66%, the
code should try to set the barrier to 70%.

The following patch does even more, it tries every value from 80%
to 10% in 10% steps, until it succeeds in lowering the performance.
I'm not sure this is the best way to do it but in any case, 
it works for me (and should continue to work for everybody else).

Stelian.

===== arch/i386/kernel/cpu/cpufreq/longrun.c 1.18 vs edited =====
--- 1.18/arch/i386/kernel/cpu/cpufreq/longrun.c	Thu Feb 19 03:48:38 2004
+++ edited/arch/i386/kernel/cpu/cpufreq/longrun.c	Mon Apr  5 17:06:12 2004
@@ -142,6 +142,7 @@
 	u32 msr_lo, msr_hi;
 	u32 save_lo, save_hi;
 	u32 eax, ebx, ecx, edx;
+	u32 try_hi;
 	struct cpuinfo_x86 *c = cpu_data;
 
 	if (!low_freq || !high_freq)
@@ -184,12 +185,14 @@
 	 * upper limit to make the calculation more accurate.
 	 */
 	cpuid(0x80860007, &eax, &ebx, &ecx, &edx);
-	if (ecx > 90) {
-		/* set to 0 to 80 perf_pctg */
+	/* try decreasing in 10% steps, some processors react only
+	 * on some barrier values */
+	for (try_hi = 80; try_hi > 0 && ecx > 90; try_hi -=10) {
+		/* set to 0 to try_hi perf_pctg */
 		msr_lo &= 0xFFFFFF80;
 		msr_hi &= 0xFFFFFF80;
 		msr_lo |= 0;
-		msr_hi |= 80;
+		msr_hi |= try_hi;
 		wrmsr(MSR_TMTA_LONGRUN_CTRL, msr_lo, msr_hi);
 
 		/* read out current core MHz and current perf_pctg */
-- 
Stelian Pop <stelian@popies.net>

             reply	other threads:[~2004-04-05 15:50 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-04-05 15:50 Stelian Pop [this message]
2004-04-05 17:38 ` [PATCH 2.6] cpufreq longrun driver fix Dominik Brodowski
2004-04-05 17:59   ` Dave Jones

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20040405155012.GI2718@deep-space-9.dsnet \
    --to=stelian@popies.net \
    --cc=cpufreq@www.linux.org.uk \
    --cc=davej@codemonkey.org.uk \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@brodo.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox