* menuconfig and UTF-8
@ 2004-04-04 12:24 Marcel Sebek
2004-04-05 21:21 ` Sam Ravnborg
0 siblings, 1 reply; 6+ messages in thread
From: Marcel Sebek @ 2004-04-04 12:24 UTC (permalink / raw)
To: linux-kernel
Hi.
I'm using UTF-8 and new changes in Makefile (2.6.5-rc3/2.6.5-final)
broke using menuconfig on linux console (xterm works ok).
$ locale
LANG=POSIX
LC_CTYPE=en_US.UTF-8
LC_NUMERIC="POSIX"
LC_TIME="POSIX"
LC_COLLATE="POSIX"
LC_MONETARY="POSIX"
LC_MESSAGES="POSIX"
LC_PAPER="POSIX"
LC_NAME="POSIX"
LC_ADDRESS="POSIX"
LC_TELEPHONE="POSIX"
LC_MEASUREMENT="POSIX"
LC_IDENTIFICATION="POSIX"
LC_ALL=
This patch fixes it:
diff -urN linux-2.6/Makefile linux-2.6-new/Makefile
--- linux-2.6/Makefile 2004-04-04 14:20:16.000000000 +0200
+++ linux-2.6-new/Makefile 2004-04-04 14:22:18.000000000 +0200
@@ -114,7 +114,6 @@
LC_ALL :=
endif
LC_COLLATE := C
-LC_CTYPE := C
export LANG LC_ALL LC_COLLATE LC_CTYPE
srctree := $(if $(KBUILD_SRC),$(KBUILD_SRC),$(CURDIR))
--
Marcel Sebek
jabber: sebek@jabber.cz ICQ: 279852819
linux user number: 307850 GPG ID: 5F88735E
GPG FP: 0F01 BAB8 3148 94DB B95D 1FCA 8B63 CA06 5F88 735E
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: menuconfig and UTF-8
2004-04-04 12:24 menuconfig and UTF-8 Marcel Sebek
@ 2004-04-05 21:21 ` Sam Ravnborg
2004-04-06 18:40 ` Marcel Sebek
0 siblings, 1 reply; 6+ messages in thread
From: Sam Ravnborg @ 2004-04-05 21:21 UTC (permalink / raw)
To: linux-kernel
On Sun, Apr 04, 2004 at 02:24:26PM +0200, Marcel Sebek wrote:
> Hi.
>
> I'm using UTF-8 and new changes in Makefile (2.6.5-rc3/2.6.5-final)
> broke using menuconfig on linux console (xterm works ok).
Could you please explain how it 'broke' menuconfig.
It works for me, but I have no fancy locale setup.
Thanks,
Sam
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: menuconfig and UTF-8
2004-04-05 21:21 ` Sam Ravnborg
@ 2004-04-06 18:40 ` Marcel Sebek
2004-04-06 18:56 ` Måns Rullgård
0 siblings, 1 reply; 6+ messages in thread
From: Marcel Sebek @ 2004-04-06 18:40 UTC (permalink / raw)
To: linux-kernel
On Mon, Apr 05, 2004 at 11:21:48PM +0200, Sam Ravnborg wrote:
> On Sun, Apr 04, 2004 at 02:24:26PM +0200, Marcel Sebek wrote:
> > Hi.
> >
> > I'm using UTF-8 and new changes in Makefile (2.6.5-rc3/2.6.5-final)
> > broke using menuconfig on linux console (xterm works ok).
>
> Could you please explain how it 'broke' menuconfig.
> It works for me, but I have no fancy locale setup.
>
I have LC_CTYPE=en_US.UTF-8. No LC_ALL or other locale variables set.
I run unicode_start on console and then menuconfig stops working right.
It prints ISO-8859-1 chars to UTF-8 terminal, which causes incorrect
indentation (UTF-8 has multi byte chars) and absence of frames.
I cannot get screenshot from console because I don't use framebuffer
and in xterm it works correctly (don't know why).
--
Marcel Sebek
jabber: sebek@jabber.cz ICQ: 279852819
linux user number: 307850 GPG ID: 5F88735E
GPG FP: 0F01 BAB8 3148 94DB B95D 1FCA 8B63 CA06 5F88 735E
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: menuconfig and UTF-8
2004-04-06 18:40 ` Marcel Sebek
@ 2004-04-06 18:56 ` Måns Rullgård
2004-04-06 19:22 ` Marcel Sebek
0 siblings, 1 reply; 6+ messages in thread
From: Måns Rullgård @ 2004-04-06 18:56 UTC (permalink / raw)
To: linux-kernel
sebek64@post.cz (Marcel Sebek) writes:
> I cannot get screenshot from console because I don't use framebuffer
> and in xterm it works correctly (don't know why).
cat /dev/vcsX
--
Måns Rullgård
mru@kth.se
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: menuconfig and UTF-8
2004-04-06 18:56 ` Måns Rullgård
@ 2004-04-06 19:22 ` Marcel Sebek
2004-04-18 11:35 ` Marcel Sebek
0 siblings, 1 reply; 6+ messages in thread
From: Marcel Sebek @ 2004-04-06 19:22 UTC (permalink / raw)
To: linux-kernel; +Cc: sam, mru
[-- Attachment #1: Type: text/plain, Size: 519 bytes --]
On Tue, Apr 06, 2004 at 08:56:47PM +0200, Måns Rullgård wrote:
> sebek64@post.cz (Marcel Sebek) writes:
>
> > I cannot get screenshot from console because I don't use framebuffer
> > and in xterm it works correctly (don't know why).
>
> cat /dev/vcsX
>
>
Thanks. I've attached both correct and incorrect screenshots.
--
Marcel Sebek
jabber: sebek@jabber.cz ICQ: 279852819
linux user number: 307850 GPG ID: 5F88735E
GPG FP: 0F01 BAB8 3148 94DB B95D 1FCA 8B63 CA06 5F88 735E
[-- Attachment #2: screenshot_good --]
[-- Type: text/plain, Size: 2000 bytes --]
Linux Kernel v2.6.5 Configuration ------------------------------------------------------------------------------ +---------------------- Linux Kernel Configuration -----------------------+ | Arrow keys navigate the menu. <Enter> selects submenus --->. | | Highlighted letters are hotkeys. Pressing <Y> includes, <N> excludes, | | <M> modularizes features. Press <Esc><Esc> to exit, <?> for Help. | | Legend: [*] built-in [ ] excluded <M> module < > module capable | | +---------------------------------------------------------------------+ | | | Code maturity level options ---> | | | | General setup ---> | | | | Loadable module support ---> | | | | Processor type and features ---> | | | | Power management options (ACPI, APM) ---> | | | | Bus options (PCI, PCMCIA, EISA, MCA, ISA) ---> | | | | Executable file formats ---> | | | | Device Drivers ---> | | | | File systems ---> | | | | Profiling support ---> | | | | Kernel hacking ---> | | | +--------v(+)---------------------------------------------------------+ | +-------------------------------------------------------------------------+ | <Select> < Exit > < Help > | +-------------------------------------------------------------------------+
[-- Attachment #3: screenshot_bad --]
[-- Type: text/plain, Size: 2000 bytes --]
Linux Kernel v2.6.5 Configuration Linux Kernel Configuration Arrow keys navigate the menu. <Enter> selects submenus --->. Highlighted letters are hotkeys. Pressing <Y> includes, <N> excludes, <M> modularizes features. Press <Esc><Esc> to exit, <?> for Help. Legend: [*] built-in [ ] excluded <M> module < > module capable Code maturity level options ---> General setup ---> Loadable module support ---> Processor type and features ---> Power management options (ACPI, APM) ---> Bus options (PCI, PCMCIA, EISA, MCA, ISA) ---> Executable file formats ---> Device Drivers ---> File systems ---> Profiling support ---> Kernel hacking ---> (+) <Select> < Exit > < Help >
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: menuconfig and UTF-8
2004-04-06 19:22 ` Marcel Sebek
@ 2004-04-18 11:35 ` Marcel Sebek
0 siblings, 0 replies; 6+ messages in thread
From: Marcel Sebek @ 2004-04-18 11:35 UTC (permalink / raw)
To: linux-kernel, sam
Here is another patch. It saves LC_CTYPE value to a temporary variable
and restores it for *config targets. It fixes the problem with
menuconfig and UTF-8 console.
diff -urN linux-2.6/Makefile linux-2.6-new/Makefile
--- linux-2.6/Makefile 2004-04-18 13:20:47.000000000 +0200
+++ linux-2.6-new/Makefile 2004-04-18 13:26:31.000000000 +0200
@@ -131,14 +131,20 @@
endif
# Make sure we're not wasting cpu-cycles doing locale handling, yet do make
-# sure error messages appear in the user-desired language
+# sure error messages appear in the user-desired language and LC_CTYPE is
+# preserved for *config targets
ifdef LC_ALL
LANG := $(LC_ALL)
LC_ALL :=
endif
LC_COLLATE := C
+ifdef LC_CTYPE
+SAVED_LC_CTYPE := $(LC_CTYPE)
+else
+SAVED_LC_CTYPE := C
+endif
LC_CTYPE := C
-export LANG LC_ALL LC_COLLATE LC_CTYPE
+export LANG LC_ALL LC_COLLATE LC_CTYPE SAVED_LC_CTYPE
srctree := $(if $(KBUILD_SRC),$(KBUILD_SRC),$(CURDIR))
TOPDIR := $(srctree)
diff -urN linux-2.6/scripts/kconfig/Makefile linux-2.6-new/scripts/kconfig/Makefile
--- linux-2.6/scripts/kconfig/Makefile 2004-04-18 13:27:37.000000000 +0200
+++ linux-2.6-new/scripts/kconfig/Makefile 2004-04-18 13:27:56.000000000 +0200
@@ -4,6 +4,9 @@
.PHONY: oldconfig xconfig gconfig menuconfig config silentoldconfig
+LC_CTYPE := $(SAVED_LC_CTYPE)
+export LC_CTYPE
+
xconfig: $(obj)/qconf
$< arch/$(ARCH)/Kconfig
--
Marcel Sebek
jabber: sebek@jabber.cz ICQ: 279852819
linux user number: 307850 GPG ID: 5F88735E
GPG FP: 0F01 BAB8 3148 94DB B95D 1FCA 8B63 CA06 5F88 735E
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2004-04-18 11:35 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2004-04-04 12:24 menuconfig and UTF-8 Marcel Sebek
2004-04-05 21:21 ` Sam Ravnborg
2004-04-06 18:40 ` Marcel Sebek
2004-04-06 18:56 ` Måns Rullgård
2004-04-06 19:22 ` Marcel Sebek
2004-04-18 11:35 ` Marcel Sebek
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox