From: Andi Kleen <ak@suse.de>
To: Anton Blanchard <anton@samba.org>
Cc: david@gibson.dropbear.id.au, akpm@osdl.org,
linux-kernel@vger.kernel.org, benh@kernel.crashing.org,
paulus@samba.org, linuxppc64-dev@lists.linuxppc.org
Subject: Re: RFC: COW for hugepages
Date: Wed, 7 Apr 2004 16:50:41 +0200 [thread overview]
Message-ID: <20040407165041.23d8d82a.ak@suse.de> (raw)
In-Reply-To: <20040407142748.GO26474@krispykreme>
On Thu, 8 Apr 2004 00:27:48 +1000
Anton Blanchard <anton@samba.org> wrote:
>
> > Implementing this for ppc64 only is just wrong. Before you do this
> > I would suggest to factor out the common code in the various hugetlbpage
> > implementations and then implement it in common code.
>
> I could say a similar thing about your i386 specific largepage modifications
> in the NUMA api :)
All they did was to modify the code to lazy faulting. That is architecture specific
(and add the mpol code, but that was pretty minor)
COW is a different thing though.
>
> We should probably look at making lots of the arch specific hugetlb code
> common but im not sure we want that to become a prerequisite for merging
> NUMA API and hugepage COW.
That would just make the merging later harder. Making it common first and then
adding features would be better.
-Andi
next prev parent reply other threads:[~2004-04-07 14:50 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-04-07 7:42 RFC: COW for hugepages David Gibson
2004-04-07 7:53 ` Andrew Morton
2004-04-07 8:03 ` Anton Blanchard
2004-04-07 8:29 ` Benjamin Herrenschmidt
2004-04-08 1:57 ` David Gibson
2004-04-07 9:00 ` Zoltan Menyhart
2004-04-08 1:53 ` David Gibson
2004-04-08 11:10 ` Zoltan Menyhart
2004-04-08 14:19 ` David Gibson
2004-04-07 12:34 ` Andi Kleen
2004-04-07 14:27 ` Anton Blanchard
2004-04-07 14:50 ` Andi Kleen [this message]
2004-04-07 21:41 ` Anton Blanchard
2004-04-07 21:47 ` Andi Kleen
2004-04-08 1:11 ` Benjamin Herrenschmidt
2004-04-08 2:01 ` Andrew Morton
2004-04-08 3:09 ` David Gibson
2004-04-08 3:24 ` Andrew Morton
2004-04-08 3:56 ` David Gibson
2004-04-08 1:50 ` David Gibson
2004-04-07 15:21 ` Dave Hansen
2004-04-08 3:22 ` David Gibson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040407165041.23d8d82a.ak@suse.de \
--to=ak@suse.de \
--cc=akpm@osdl.org \
--cc=anton@samba.org \
--cc=benh@kernel.crashing.org \
--cc=david@gibson.dropbear.id.au \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc64-dev@lists.linuxppc.org \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).