From: Greg KH <greg@kroah.com>
To: linux-kernel@vger.kernel.org, tim@cyberelk.net
Subject: Re: [PATCH 2.6] Class support for ppdev.c
Date: Sat, 10 Apr 2004 10:01:48 -0700 [thread overview]
Message-ID: <20040410170148.GI1317@kroah.com> (raw)
In-Reply-To: <20040410135115.GA3612@penguin.localdomain>
On Sat, Apr 10, 2004 at 03:51:15PM +0200, Marcel Sebek wrote:
> This patch adds class support to ppdev.c.
>
> The module compiles and loads ok.
Looks good, but we really shoulnd't be duplicating the devfs
functionality here. We should only show the devices that the system
really has present, instead of always showing all of the devices. Care
to fix your patch up to implement this instead?
thanks,
greg k-h
next prev parent reply other threads:[~2004-04-10 17:02 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-04-10 13:51 [PATCH 2.6] Class support for ppdev.c Marcel Sebek
2004-04-10 17:01 ` Greg KH [this message]
2004-04-10 18:06 ` Marcel Sebek
2004-04-10 19:46 ` Marcel Sebek
2004-04-10 20:28 ` viro
2004-04-11 8:25 ` Marcel Sebek
2004-04-12 18:51 ` Greg KH
2004-04-13 17:29 ` Marcel Sebek
2004-05-02 6:29 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040410170148.GI1317@kroah.com \
--to=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
--cc=tim@cyberelk.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox