From: Andrew Morton <akpm@osdl.org>
To: Samium Gromoff <deepfire@sic-elvis.zel.ru>
Cc: linux-kernel@vger.kernel.org, Ralf Baechle <ralf@linux-mips.org>
Subject: Re: [2.6.5][MIPS] oneliners somehow not made it into mainline [3/3]
Date: Mon, 12 Apr 2004 14:06:28 -0700 [thread overview]
Message-ID: <20040412140628.4836d778.akpm@osdl.org> (raw)
In-Reply-To: <87hdvpp8km.wl@canopus.ns.zel.ru>
Samium Gromoff <deepfire@sic-elvis.zel.ru> wrote:
>
> Without this one it fails to run the earlyinitcall stuff, and hence
> explodes at some point.
>
> diff -urN -X './#cdiff.pattern' ./linux-2.6.5/include/linux/init.h ./mc-2.6.5/include/linux/init.h
> --- ./linux-2.6.5/include/linux/init.h 2004-04-12 16:07:45.000000000 +0400
> +++ ./mc-2.6.5/include/linux/init.h 2004-04-12 18:05:28.000000000 +0400
> @@ -83,6 +83,7 @@
> static initcall_t __initcall_##fn __attribute_used__ \
> __attribute__((__section__(".initcall" level ".init"))) = fn
>
> +#define early_initcall(fn) __define_initcall(".early1",fn)
> #define core_initcall(fn) __define_initcall("1",fn)
> #define postcore_initcall(fn) __define_initcall("2",fn)
> #define arch_initcall(fn) __define_initcall("3",fn)
early_initcall() is a mips-specific thing. If we add this macro to
<linux/init.h> then someone will use it in generic code and all the other
architectures explode.
We need to either make this entirely mips-private, or rework the mips code
to not use it at all, or justify its introduction and then introduce it for
all architectures.
prev parent reply other threads:[~2004-04-12 21:04 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-04-12 14:32 [2.6.5][MIPS] oneliners somehow not made it into mainline [1/3] Samium Gromoff
2004-04-12 14:34 ` [2.6.5][MIPS] oneliners somehow not made it into mainline [2/3] Samium Gromoff
2004-04-12 14:36 ` [2.6.5][MIPS] oneliners somehow not made it into mainline [3/3] Samium Gromoff
2004-04-12 21:06 ` Andrew Morton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040412140628.4836d778.akpm@osdl.org \
--to=akpm@osdl.org \
--cc=deepfire@sic-elvis.zel.ru \
--cc=linux-kernel@vger.kernel.org \
--cc=ralf@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox