From: Greg KH <greg@kroah.com>
To: viro@parcelfarce.linux.theplanet.co.uk,
linux-kernel@vger.kernel.org, tim@cyberelk.net
Subject: Re: [PATCH 2.6] Class support for ppdev.c
Date: Mon, 12 Apr 2004 11:51:21 -0700 [thread overview]
Message-ID: <20040412185121.GD21502@kroah.com> (raw)
In-Reply-To: <20040411082553.GA2499@penguin.localdomain>
On Sun, Apr 11, 2004 at 10:25:53AM +0200, Marcel Sebek wrote:
> On Sat, Apr 10, 2004 at 09:28:59PM +0100, viro@parcelfarce.linux.theplanet.co.uk wrote:
> > On Sat, Apr 10, 2004 at 09:46:01PM +0200, Marcel Sebek wrote:
> > > And new updated patch. partport_find_number() needs to decrement refcount
> > > by parport_put_port().
> >
> > And it's still broken. New parports can appear at any point - hell, we even
> > have USB->parport converters. IOW, if you want to do something useful here -
> > use ->attach()/->detach() of parport_driver.
> >
> Ok. Here's new one. It uses attach()/detach() callbacks for creating
> udev and devfs files.
Looks much better, thanks. But please don't modify the current devfs
usage, those users will generally not like that. Can you redo this
patch to only add the sysfs changes?
thanks,
greg k-h
next prev parent reply other threads:[~2004-04-12 18:55 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-04-10 13:51 [PATCH 2.6] Class support for ppdev.c Marcel Sebek
2004-04-10 17:01 ` Greg KH
2004-04-10 18:06 ` Marcel Sebek
2004-04-10 19:46 ` Marcel Sebek
2004-04-10 20:28 ` viro
2004-04-11 8:25 ` Marcel Sebek
2004-04-12 18:51 ` Greg KH [this message]
2004-04-13 17:29 ` Marcel Sebek
2004-05-02 6:29 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040412185121.GD21502@kroah.com \
--to=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
--cc=tim@cyberelk.net \
--cc=viro@parcelfarce.linux.theplanet.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox