Re: [PATCH 2.6] Class support for ppdev.c

Greg KH
2004-04-12T18:55:48Z

On Sun, Apr 11, 2004 at 10:25:53AM +0200, Marcel Sebek wrote:
> On Sat, Apr 10, 2004 at 09:28:59PM +0100, viro@parcelfarce.linux.theplanet.co.uk wrote:
> > On Sat, Apr 10, 2004 at 09:46:01PM +0200, Marcel Sebek wrote:
> > > And new updated patch. partport_find_number() needs to decrement refcount
> > > by parport_put_port().
> >
> > And it's still broken. New parports can appear at any point - hell, we even
> > have USB->parport converters. IOW, if you want to do something useful here -
> > use ->attach()/->detach() of parport_driver.
> >
> Ok. Here's new one. It uses attach()/detach() callbacks for creating
> udev and devfs files.

Looks much better, thanks. But please don't modify the current devfs
usage, those users will generally not like that. Can you redo this
patch to only add the sysfs changes?

thanks,

greg k-h