From: Andrew Morton <akpm@osdl.org>
To: Albert Cahalan <albert@users.sourceforge.net>
Cc: linux-kernel@vger.kernel.org, mpm@selenic.com
Subject: Re: [PATCH] eliminate nswap and cnswap
Date: Mon, 12 Apr 2004 20:42:23 -0700 [thread overview]
Message-ID: <20040412204223.2a07d123.akpm@osdl.org> (raw)
In-Reply-To: <1081827102.1593.227.camel@cube>
Albert Cahalan <albert@users.sourceforge.net> wrote:
>
> > The nswap and cnswap variables counters have never
> > been incremented as Linux doesn't do task swapping.
>
> I'm pretty sure they were used for paging activity.
> We don't eliminate support for "swap space", do we?
>
> Somebody must have broken nswap and cnswap while
> hacking on some vm code. I hate to see the variables
> get completely ripped out of the kernel instead of
> getting fixed.
There's nothing in 2.4 which increments these, nor was there in 2.6. Which
tends to imply that they weren't very important.
We could sort-of do this - move them into mm_struct (doing it in
task_struct was always wrong) and increment them in the VM. But we'd need
some reason why these statistics are interesting, and we'd need an
explanation of what nswap and cnswap are actually supposed to represent.
next prev parent reply other threads:[~2004-04-13 3:42 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-04-13 3:31 [PATCH] eliminate nswap and cnswap Albert Cahalan
2004-04-13 3:42 ` Andrew Morton [this message]
2004-04-13 4:27 ` Matt Mackall
2004-04-13 4:47 ` Albert Cahalan
2004-04-13 16:56 ` Bill Davidsen
-- strict thread matches above, loose matches on Subject: below --
2004-04-03 4:18 Matt Mackall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040412204223.2a07d123.akpm@osdl.org \
--to=akpm@osdl.org \
--cc=albert@users.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=mpm@selenic.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox