public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Sam Ravnborg <sam@ravnborg.org>
To: Andrew Vasquez <praka@users.sourceforge.net>,
	linux-kernel@vger.kernel.org, sam@ravnborg.org,
	Marcus Hartig <m.f.h@web.de>
Subject: Re: 2.6.5-mm4
Date: Tue, 13 Apr 2004 06:54:19 +0200	[thread overview]
Message-ID: <20040413045419.GA2199@mars.ravnborg.org> (raw)
In-Reply-To: <20040412201524.GA31684@praka.local.home>

On Mon, Apr 12, 2004 at 01:15:24PM -0700, Andrew Vasquez wrote:
> With 2.6.5-mm4 a similar command fails with:
> 
> 	-bash-2.05b# make -C /usr/src/linux-2.6.5-mm4 SUBDIRS=$PWD modules
> 	make: Entering directory `/usr/src/linux-2.6.5-mm4'
> 	  CC [M]  /root/Drivers/8.x/80000b12-pre14/ql2300.o
> 	  CC [M]  /root/Drivers/8.x/80000b12-pre14/ql2300_fw.o
> 	  CC [M]  /root/Drivers/8.x/80000b12-pre14/qla_os.o
> 	  CC [M]  /root/Drivers/8.x/80000b12-pre14/qla_init.o
> 	  CC [M]  /root/Drivers/8.x/80000b12-pre14/qla_mbx.o
> 	  CC [M]  /root/Drivers/8.x/80000b12-pre14/qla_iocb.o
> 	  CC [M]  /root/Drivers/8.x/80000b12-pre14/qla_isr.o
> 	  CC [M]  /root/Drivers/8.x/80000b12-pre14/qla_gs.o
> 	  CC [M]  /root/Drivers/8.x/80000b12-pre14/qla_dbg.o
> 	  CC [M]  /root/Drivers/8.x/80000b12-pre14/qla_sup.o
> 	  CC [M]  /root/Drivers/8.x/80000b12-pre14/qla_rscn.o
> 	  LD [M]  /root/Drivers/8.x/80000b12-pre14/qla2xxx.o
> 	/bin/sh: line 1:
> 	/root/Drivers/8.x/80000b12-pre14/.tmp_versions/qla2xxx.mod: No such
> 	file or directory

The external module support failed to create the directory:
$PWD/.tmp_version

It was no deleted during make clean either - thats why it slipped through.
Here is a patch to fix it.

	Sam

--- linux-2.6.5/Makefile	2004-04-12 20:58:30.000000000 +0200
+++ extmod/Makefile	2004-04-12 20:46:24.000000000 +0200
@@ -787,12 +787,6 @@ endef
 # make mrproper  Delete the current configuration, and all generated files
 # make distclean Remove editor backup files, patch leftover files and the like
 
-quiet_cmd_rmdirs = $(if $(wildcard $(rm-dirs)),CLEAN   $(wildcard $(rm-dirs)))
-      cmd_rmdirs = rm -rf $(rm-dirs)
-
-quiet_cmd_rmfiles = $(if $(wildcard $(rm-files)),CLEAN   $(wildcard $(rm-files)))
-      cmd_rmfiles = rm -f $(rm-files)
-
 # Directories & files removed with 'make clean'
 CLEAN_DIRS  += $(MODVERDIR)
 CLEAN_FILES +=	vmlinux System.map kernel.spec \
@@ -951,9 +945,12 @@ else # KBUILD_EXTMOD
 
 # We are always building modules
 KBUILD_MODULES := 1
+.PHONY: crmodverdir
+crmodverdir: FORCE
+	$(Q)mkdir -p $(MODVERDIR)
 
 .PHONY: $(KBUILD_EXTMOD)
-$(KBUILD_EXTMOD): FORCE
+$(KBUILD_EXTMOD): crmodverdir FORCE
 	$(Q)$(MAKE) $(build)=$@
 
 .PHONY: modules
@@ -971,7 +968,9 @@ clean-dirs := _clean_$(KBUILD_EXTMOD)
 $(clean-dirs):
 	$(Q)$(MAKE) $(clean)=$(patsubst _clean_%,%,$@)
 
+clean:	rm-dirs := $(MODVERDIR)
 clean: $(clean-dirs)
+	$(call cmd,rmdirs)
 	@find $(KBUILD_EXTMOD) $(RCS_FIND_IGNORE) \
 	 	\( -name '*.[oas]' -o -name '*.ko' -o -name '.*.cmd' \
 		-o -name '.*.d' -o -name '.*.tmp' -o -name '*.mod.c' \) \
@@ -1058,6 +1057,13 @@ endif #ifeq ($(mixed-targets),1)
 # FIXME Should go into a make.lib or something 
 # ===========================================================================
 
+quiet_cmd_rmdirs = $(if $(wildcard $(rm-dirs)),CLEAN   $(wildcard $(rm-dirs)))
+      cmd_rmdirs = rm -rf $(rm-dirs)
+
+quiet_cmd_rmfiles = $(if $(wildcard $(rm-files)),CLEAN   $(wildcard $(rm-files)))
+      cmd_rmfiles = rm -f $(rm-files)
+
+
 a_flags = -Wp,-MD,$(depfile) $(AFLAGS) $(AFLAGS_KERNEL) \
 	  $(NOSTDINC_FLAGS) $(CPPFLAGS) \
 	  $(modkern_aflags) $(EXTRA_AFLAGS) $(AFLAGS_$(*F).o)

  reply	other threads:[~2004-04-13  4:47 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-04-12 19:19 2.6.5-mm4 Marcus Hartig
2004-04-12 19:35 ` 2.6.5-mm4 Marc-Christian Petersen
2004-04-12 19:52   ` 2.6.5-mm4 Sam Ravnborg
2004-04-12 19:56 ` 2.6.5-mm4 Sam Ravnborg
2004-04-12 20:15   ` 2.6.5-mm4 Andrew Vasquez
2004-04-13  4:54     ` Sam Ravnborg [this message]
2004-04-12 20:48   ` 2.6.5-mm4 Marcus Hartig
2004-04-13  2:47     ` 2.6.5-mm4 Michael Baehr
2004-04-13  4:58     ` 2.6.5-mm4 Sam Ravnborg
  -- strict thread matches above, loose matches on Subject: below --
2004-04-13 15:22 2.6.5-mm4 Andrew Vasquez
2004-04-11  3:05 2.6.5-mm4 Andrew Morton
2004-04-12  6:46 ` 2.6.5-mm4 Paul P Komkoff Jr
2004-04-12  7:42   ` 2.6.5-mm4 Andrew Morton
2004-04-12  8:22     ` 2.6.5-mm4 Paul P Komkoff Jr
2004-04-12  8:28       ` 2.6.5-mm4 Andrew Morton
2004-04-12  9:10         ` 2.6.5-mm4 Paul P Komkoff Jr

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20040413045419.GA2199@mars.ravnborg.org \
    --to=sam@ravnborg.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=m.f.h@web.de \
    --cc=praka@users.sourceforge.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox