Re: [PATCH] conditionalize some boring buffer_head checks

Matt Mackall
2004-04-14T21:49:36Z

On Wed, Apr 14, 2004 at 05:33:36PM -0400, Jeff Garzik wrote:
> On Wed, Apr 14, 2004 at 04:25:39PM -0500, Matt Mackall wrote:
> > Sticking this in arch/*/Kconfig seems silly (as does much of the
> > duplication in said files). Can we stick this and other debug bits
> > under the kallsyms option in init/Kconfig instead? Or alternately move
> > debugging bits into their own file that gets included as appropriate.
>
> I would rather have an arch/generic/Kconfig.debug file that gets
> included. init/Kconfig may be generic, but its name hardly implies its
> purpose as used.

Yes, and it's rather a dumping ground too.

> There are clearly two classes of debug options, one arch-specific, and
> one not.

There is a third class of options that aren't intrinsically
arch-specific, but are currently implemented on only a subset of
architectures (eg kgdb), that I would argue properly belong in the
generic debug section.

--
Matt Mackall : http://www.selenic.com : Linux development and consulting