From: Duncan Sands <baldrick@free.fr>
To: Oliver Neukum <oliver@neukum.org>, Greg KH <greg@kroah.com>
Cc: linux-usb-devel@lists.sourceforge.net,
linux-kernel@vger.kernel.org, Frederic Detienne <fd@cisco.com>
Subject: Re: [linux-usb-devel] [PATCH 7/9] USB usbfs: destroy submitted urbs only on the disconnected interface
Date: Wed, 14 Apr 2004 15:38:19 +0200 [thread overview]
Message-ID: <200404141538.19189.baldrick@free.fr> (raw)
In-Reply-To: <200404141530.54093.oliver@neukum.org>
On Wednesday 14 April 2004 15:30, Oliver Neukum wrote:
> Am Mittwoch, 14. April 2004 12:45 schrieb Duncan Sands:
> > The remaining three patches contain miscellaneous fixes to usbfs.
> > This one fixes up the disconnect callback to only shoot down urbs
> > on the disconnected interface, and not on all interfaces. It also adds
> > a sanity check (this check is pointless because the interface could
> > never have been claimed in the first place if it failed, but I feel
> > better having it there).
>
> Well, I don't. If you care about it, add a WARN_ON().
> Checking without consequences is bad.
If the check fails then you are scribbling over kernel memory. So the
consequences of the check failing are bad. Also, it is in a slow path.
Thus I prefer to have the check even if it is supposed to never fail. I
agree that a message should also be output.
Duncan.
next prev parent reply other threads:[~2004-04-14 13:38 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-04-14 10:45 [PATCH 7/9] USB usbfs: destroy submitted urbs only on the disconnected interface Duncan Sands
2004-04-14 13:30 ` [linux-usb-devel] " Oliver Neukum
2004-04-14 13:38 ` Duncan Sands [this message]
2004-04-14 15:00 ` Duncan Sands
2004-04-14 15:33 ` Oliver Neukum
2004-04-14 15:39 ` Duncan Sands
2004-04-14 20:39 ` Oliver Neukum
2004-04-15 8:05 ` Duncan Sands
2004-04-15 8:31 ` Oliver Neukum
2004-04-15 8:47 ` Duncan Sands
2004-04-15 9:08 ` Oliver Neukum
2004-04-15 9:21 ` Duncan Sands
2004-04-14 16:48 ` Alan Stern
2004-04-14 17:09 ` Duncan Sands
2004-04-14 17:55 ` Alan Stern
2004-04-17 18:31 ` Duncan Sands
2004-04-17 18:53 ` Duncan Sands
2004-04-17 19:52 ` Alan Stern
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200404141538.19189.baldrick@free.fr \
--to=baldrick@free.fr \
--cc=fd@cisco.com \
--cc=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb-devel@lists.sourceforge.net \
--cc=oliver@neukum.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox