From: Andrew Morton <akpm@osdl.org>
To: Nathan Lynch <nathanl@austin.ibm.com>
Cc: linux-kernel@vger.kernel.org, olof@austin.ibm.com
Subject: Re: [PATCH] Increase number of dynamic inodes in procfs (2.6.5)
Date: Wed, 14 Apr 2004 20:21:53 -0700 [thread overview]
Message-ID: <20040414202153.731d6933.akpm@osdl.org> (raw)
In-Reply-To: <407DFDE7.5050803@austin.ibm.com>
Nathan Lynch <nathanl@austin.ibm.com> wrote:
>
> Andrew Morton wrote:
> > Nathan Lynch <nathanl@austin.ibm.com> wrote:
> >
> >>>This open-codes a simple version of lib/idr.c. Please use lib/idr.c
> >>
> >> > instead. There's an example in fs/super.c
> >>
> >> Ok, thanks for the tip. Is this better?
> >
> >
> > Looks OK. How well tested was it? Nothing calls init_proc_inum_idr().
> > Maybe all-zeroes happens to work.
>
> Sorry, I tested it all day; it just happens to work :)
heh. It gave me an instasplat with spinlock debugging enabled.
> I think
> the call to idr_remove in fs/super.c::set_anon_super needs to be holding
> unnamed_dev_lock.
Indeed. I'll fix that up, thanks.
prev parent reply other threads:[~2004-04-15 3:22 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-04-13 19:36 [PATCH] Increase number of dynamic inodes in procfs (2.6.5) Nathan Lynch
2004-04-14 0:06 ` Andrew Morton
2004-04-14 5:01 ` Olof Johansson
2004-04-14 5:06 ` Olof Johansson
2004-04-14 5:19 ` Andrew Morton
2004-04-15 2:38 ` Nathan Lynch
2004-04-15 2:51 ` Andrew Morton
2004-04-15 3:13 ` Nathan Lynch
2004-04-15 3:21 ` Andrew Morton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040414202153.731d6933.akpm@osdl.org \
--to=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nathanl@austin.ibm.com \
--cc=olof@austin.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox