public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Dave Jones <davej@redhat.com>
To: Linus Torvalds <torvalds@osdl.org>, Andrew Morton <akpm@osdl.org>,
	mingo@redhat.com
Cc: Linux Kernel <linux-kernel@vger.kernel.org>
Subject: fix __exit_mm() dereference before check.
Date: Fri, 16 Apr 2004 22:08:28 +0100	[thread overview]
Message-ID: <20040416210828.GK20937@redhat.com> (raw)

>From a quick look, it appears passing NULL mm's down to mm_release()
isn't a good idea.

		Dave


--- linux-2.6.5/kernel/exit.c~	2004-04-16 22:06:00.000000000 +0100
+++ linux-2.6.5/kernel/exit.c	2004-04-16 22:06:51.000000000 +0100
@@ -482,9 +482,10 @@
 {
 	struct mm_struct *mm = tsk->mm;
 
-	mm_release(tsk, mm);
 	if (!mm)
 		return;
+	mm_release(tsk, mm);
+
 	/*
 	 * Serialize with any possible pending coredump.
 	 * We must hold mmap_sem around checking core_waiters

             reply	other threads:[~2004-04-16 21:09 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-04-16 21:08 Dave Jones [this message]
2004-04-16 22:01 ` fix __exit_mm() dereference before check Linus Torvalds
2004-04-16 22:13   ` Dave Jones

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20040416210828.GK20937@redhat.com \
    --to=davej@redhat.com \
    --cc=akpm@osdl.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=torvalds@osdl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox