From: Dave Jones <davej@redhat.com>
To: trond.myklebust@fys.uio.no
Cc: Linux Kernel <linux-kernel@vger.kernel.org>
Subject: NFS thinko
Date: Fri, 16 Apr 2004 22:16:28 +0100 [thread overview]
Message-ID: <20040416211628.GM20937@redhat.com> (raw)
Dereferencing 'exp' before the check for NULL.
Dave
--- linux-2.6.5/include/linux/nfsd/export.h~ 2004-04-16 22:13:28.000000000 +0100
+++ linux-2.6.5/include/linux/nfsd/export.h 2004-04-16 22:14:21.000000000 +0100
@@ -118,13 +118,15 @@
if (ek && !IS_ERR(ek)) {
struct svc_export *exp = ek->ek_export;
int err;
+ if (!exp)
+ goto out;
cache_get(&exp->h);
expkey_put(&ek->h, &svc_expkey_cache);
- if (exp &&
- (err = cache_check(&svc_export_cache, &exp->h, reqp)))
+ if (err = cache_check(&svc_export_cache, &exp->h, reqp))
exp = ERR_PTR(err);
return exp;
} else
+out:
return ERR_PTR(PTR_ERR(ek));
}
next reply other threads:[~2004-04-16 21:17 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-04-16 21:16 Dave Jones [this message]
2004-04-16 21:32 ` NFS thinko Russell King
2004-04-16 22:09 ` J. Bruce Fields
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040416211628.GM20937@redhat.com \
--to=davej@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=trond.myklebust@fys.uio.no \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox