From: Dave Jones <davej@redhat.com>
To: jgarzik@pobox.com
Cc: Linux Kernel <linux-kernel@vger.kernel.org>
Subject: baycom_par dereference before check.
Date: Fri, 16 Apr 2004 22:20:04 +0100 [thread overview]
Message-ID: <20040416212004.GO20937@redhat.com> (raw)
--- linux-2.6.5/drivers/net/hamradio/baycom_par.c~ 2004-04-16 22:18:53.000000000 +0100
+++ linux-2.6.5/drivers/net/hamradio/baycom_par.c 2004-04-16 22:19:33.000000000 +0100
@@ -272,9 +272,13 @@
static void par96_interrupt(int irq, void *dev_id, struct pt_regs *regs)
{
struct net_device *dev = (struct net_device *)dev_id;
- struct baycom_state *bc = netdev_priv(dev);
+ struct baycom_state *bc;
- if (!dev || !bc || bc->hdrv.magic != HDLCDRV_MAGIC)
+ if (!dev)
+ return;
+
+ bc = netdev_priv(dev);
+ if (!bc || bc->hdrv.magic != HDLCDRV_MAGIC)
return;
baycom_int_freq(bc);
next reply other threads:[~2004-04-16 21:21 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-04-16 21:20 Dave Jones [this message]
2004-04-16 21:25 ` baycom_par dereference before check viro
2004-04-16 21:27 ` Dave Jones
2004-04-16 21:48 ` Jeff Garzik
2004-04-16 21:53 ` Dave Jones
2004-04-16 23:07 ` Chris Wright
2004-04-16 23:40 ` Jeff Garzik
2004-04-19 16:39 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040416212004.GO20937@redhat.com \
--to=davej@redhat.com \
--cc=jgarzik@pobox.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox