* fix notify_change() potential null dereference.
@ 2004-04-16 21:37 Dave Jones
2004-04-16 21:54 ` Linus Torvalds
2004-04-16 21:57 ` Christoph Hellwig
0 siblings, 2 replies; 3+ messages in thread
From: Dave Jones @ 2004-04-16 21:37 UTC (permalink / raw)
To: Linus Torvalds, Andrew Morton; +Cc: Linux Kernel
--- linux-2.6.5/fs/attr.c~ 2004-04-16 22:36:00.000000000 +0100
+++ linux-2.6.5/fs/attr.c 2004-04-16 22:36:37.000000000 +0100
@@ -130,7 +130,7 @@
int notify_change(struct dentry * dentry, struct iattr * attr)
{
struct inode *inode = dentry->d_inode;
- mode_t mode = inode->i_mode;
+ mode_t mode;
int error;
struct timespec now = CURRENT_TIME;
unsigned int ia_valid = attr->ia_valid;
@@ -138,6 +138,7 @@
if (!inode)
BUG();
+ mode = inode->i_mode;
attr->ia_ctime = now;
if (!(ia_valid & ATTR_ATIME_SET))
attr->ia_atime = now;
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: fix notify_change() potential null dereference.
2004-04-16 21:37 fix notify_change() potential null dereference Dave Jones
@ 2004-04-16 21:54 ` Linus Torvalds
2004-04-16 21:57 ` Christoph Hellwig
1 sibling, 0 replies; 3+ messages in thread
From: Linus Torvalds @ 2004-04-16 21:54 UTC (permalink / raw)
To: Dave Jones; +Cc: Andrew Morton, Linux Kernel
I disagree on this one - at least with the message.
The fact is, "inode" can't be NULL. We have a BUG() check for it, but
getting a page fault would be equally effective.
Linus
On Fri, 16 Apr 2004, Dave Jones wrote:
>
> --- linux-2.6.5/fs/attr.c~ 2004-04-16 22:36:00.000000000 +0100
> +++ linux-2.6.5/fs/attr.c 2004-04-16 22:36:37.000000000 +0100
> @@ -130,7 +130,7 @@
> int notify_change(struct dentry * dentry, struct iattr * attr)
> {
> struct inode *inode = dentry->d_inode;
> - mode_t mode = inode->i_mode;
> + mode_t mode;
> int error;
> struct timespec now = CURRENT_TIME;
> unsigned int ia_valid = attr->ia_valid;
> @@ -138,6 +138,7 @@
> if (!inode)
> BUG();
>
> + mode = inode->i_mode;
> attr->ia_ctime = now;
> if (!(ia_valid & ATTR_ATIME_SET))
> attr->ia_atime = now;
>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: fix notify_change() potential null dereference.
2004-04-16 21:37 fix notify_change() potential null dereference Dave Jones
2004-04-16 21:54 ` Linus Torvalds
@ 2004-04-16 21:57 ` Christoph Hellwig
1 sibling, 0 replies; 3+ messages in thread
From: Christoph Hellwig @ 2004-04-16 21:57 UTC (permalink / raw)
To: Dave Jones, Linus Torvalds, Andrew Morton, Linux Kernel
On Fri, Apr 16, 2004 at 10:37:43PM +0100, Dave Jones wrote:
>
> --- linux-2.6.5/fs/attr.c~ 2004-04-16 22:36:00.000000000 +0100
> +++ linux-2.6.5/fs/attr.c 2004-04-16 22:36:37.000000000 +0100
> @@ -130,7 +130,7 @@
> int notify_change(struct dentry * dentry, struct iattr * attr)
> {
> struct inode *inode = dentry->d_inode;
> - mode_t mode = inode->i_mode;
> + mode_t mode;
Passing a NULL argument to notify_change() is invalid.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2004-04-16 22:02 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2004-04-16 21:37 fix notify_change() potential null dereference Dave Jones
2004-04-16 21:54 ` Linus Torvalds
2004-04-16 21:57 ` Christoph Hellwig
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox