From: "J. Bruce Fields" <bfields@fieldses.org>
To: Dave Jones <davej@redhat.com>,
trond.myklebust@fys.uio.no,
Linux Kernel <linux-kernel@vger.kernel.org>
Subject: Re: NFS thinko
Date: Fri, 16 Apr 2004 18:09:23 -0400 [thread overview]
Message-ID: <20040416220922.GA12062@fieldses.org> (raw)
In-Reply-To: <20040416211628.GM20937@redhat.com>
On Fri, Apr 16, 2004 at 10:16:28PM +0100, Dave Jones wrote:
> Dereferencing 'exp' before the check for NULL.
It would be a bug if exp were ever NULL there. Better just to delete
that check entirely.
--Bruce Fields
If ek = exp_find_key() is not an error, then ek->ek_export should be
set; no point in checking if it's NULL.
include/linux/nfsd/export.h | 3 +--
1 files changed, 1 insertion(+), 2 deletions(-)
diff -puN include/linux/nfsd/export.h~export_exp_deref_fix include/linux/nfsd/export.h
--- linux-2.6.6-rc1/include/linux/nfsd/export.h~export_exp_deref_fix 2004-04-16 17:51:57.000000000 -0400
+++ linux-2.6.6-rc1-bfields/include/linux/nfsd/export.h 2004-04-16 17:58:30.000000000 -0400
@@ -120,8 +120,7 @@ exp_find(struct auth_domain *clp, int fs
int err;
cache_get(&exp->h);
expkey_put(&ek->h, &svc_expkey_cache);
- if (exp &&
- (err = cache_check(&svc_export_cache, &exp->h, reqp)))
+ if ((err = cache_check(&svc_export_cache, &exp->h, reqp)))
exp = ERR_PTR(err);
return exp;
} else
_
prev parent reply other threads:[~2004-04-16 22:15 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-04-16 21:16 NFS thinko Dave Jones
2004-04-16 21:32 ` Russell King
2004-04-16 22:09 ` J. Bruce Fields [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040416220922.GA12062@fieldses.org \
--to=bfields@fieldses.org \
--cc=davej@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=trond.myklebust@fys.uio.no \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox