public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@infradead.org>
To: Dave Jones <davej@redhat.com>, Linus Torvalds <torvalds@osdl.org>,
	Andrew Morton <akpm@osdl.org>,
	Linux Kernel <linux-kernel@vger.kernel.org>
Subject: Re: fix notify_change() potential null dereference.
Date: Fri, 16 Apr 2004 22:57:41 +0100	[thread overview]
Message-ID: <20040416225741.A11576@infradead.org> (raw)
In-Reply-To: <20040416213743.GS20937@redhat.com>; from davej@redhat.com on Fri, Apr 16, 2004 at 10:37:43PM +0100

On Fri, Apr 16, 2004 at 10:37:43PM +0100, Dave Jones wrote:
> 
> --- linux-2.6.5/fs/attr.c~	2004-04-16 22:36:00.000000000 +0100
> +++ linux-2.6.5/fs/attr.c	2004-04-16 22:36:37.000000000 +0100
> @@ -130,7 +130,7 @@
>  int notify_change(struct dentry * dentry, struct iattr * attr)
>  {
>  	struct inode *inode = dentry->d_inode;
> -	mode_t mode = inode->i_mode;
> +	mode_t mode;

Passing a NULL argument to notify_change() is invalid.


      parent reply	other threads:[~2004-04-16 22:02 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-04-16 21:37 fix notify_change() potential null dereference Dave Jones
2004-04-16 21:54 ` Linus Torvalds
2004-04-16 21:57 ` Christoph Hellwig [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20040416225741.A11576@infradead.org \
    --to=hch@infradead.org \
    --cc=akpm@osdl.org \
    --cc=davej@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=torvalds@osdl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox