From: Willy Tarreau <w@w.ods.org>
To: ameer armaly <ameer@charter.net>
Cc: linux-kernel@vger.kernel.org, linus@osdl.org
Subject: Re: [patch] config option to make at keyboards beep when too many keys are pressed
Date: Mon, 19 Apr 2004 06:42:57 +0200 [thread overview]
Message-ID: <20040419044257.GH596@alpha.home.local> (raw)
In-Reply-To: <Pine.LNX.4.58.0404182147160.828@debian>
On Sun, Apr 18, 2004 at 09:49:53PM -0400, ameer armaly wrote:
> +#else
> +printk(KERN_ALERT, "\007");
> +#endif goto out;
Not speaking about poor indentation, this is not the right solution. You
will pollute system logs with \007, and you might even send the beep far
away from the keyboard, if the console is on a serial terminal. A better
solution would be to call a function which activates the local speaker,
typically the one used to output "\007" on a vt.
> +config BEEP_TOMANEY_KEYS
> +bool "Beep when too many keys are pressed on at keyboards"
> +depends on KEYBOARD_ATKBD
please respect indentation here too, just as it is below :
> config KEYBOARD_SUNKBD
> tristate "Sun Type 4 and Type 5 keyboard support"
> depends on INPUT && INPUT_KEYBOARD
Regards,
Willy
prev parent reply other threads:[~2004-04-19 4:44 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-04-19 1:49 [patch] config option to make at keyboards beep when too many keys are pressed ameer armaly
2004-04-19 4:42 ` Willy Tarreau [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040419044257.GH596@alpha.home.local \
--to=w@w.ods.org \
--cc=ameer@charter.net \
--cc=linus@osdl.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox