From: Romain Lievin <lkml@lievin.net>
To: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Cc: Greg Kroah <greg@kroah.com>,
Marcelo Tosatti <marcelo.tosatti@cyclades.com>
Subject: [PATCH] tipar char driver: wrong timeout value
Date: Mon, 19 Apr 2004 10:04:13 +0200 [thread overview]
Message-ID: <20040419080413.GA13695@lievin.net> (raw)
Hi,
this patch (2.4 & 2.6) fixes a bug about the timeout value. The formula
used to calculate jiffies from timeout is wrong.
The new formula is ok and takes care of integer computation/rounding.
There is the same bug in the tiglusb.c module which will be fixed by another
patch.
Please apply, Romain.
==============================[cut here]================================
diff -Naur linux-2.4.26.orig/drivers/char/tipar.c linux-2.4.26/drivers/char/tipar.c
--- linux-2.4.26.orig/drivers/char/tipar.c 2004-02-18 14:36:31.000000000 +0100
+++ linux-2.4.26/drivers/char/tipar.c 2004-04-19 09:22:36.000000000 +0200
@@ -124,7 +124,7 @@
/* ----- global defines ----------------------------------------------- */
-#define START(x) { x=jiffies+HZ/(timeout/10); }
+#define START(x) { x = jiffies + (HZ * timeout) / 10; }
#define WAIT(x) { \
if (time_before((x), jiffies)) return -1; \
if (need_resched()) schedule(); }
==============================[cut here]================================
diff -Naur linux-2.6.5.orig/drivers/char/tipar.c linux-2.6.5/drivers/char/tipar.c
--- linux-2.6.5.orig/drivers/char/tipar.c 2004-04-04 05:37:37.000000000 +0200
+++ linux-2.6.5/drivers/char/tipar.c 2004-04-19 09:23:25.000000000 +0200
@@ -121,7 +121,7 @@
/* ----- global defines ----------------------------------------------- */
-#define START(x) { x=jiffies+HZ/(timeout/10); }
+#define START(x) { x = jiffies + (HZ * timeout) / 10; }
#define WAIT(x) { \
if (time_before((x), jiffies)) return -1; \
if (need_resched()) schedule(); }
==============================[cut here]================================
--
Romain Liévin (roms): <lkml@lievin.net>
Web site: http://www.lievin.net
"Linux, y'a moins bien mais c'est plus cher !"
reply other threads:[~2004-04-19 8:04 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040419080413.GA13695@lievin.net \
--to=lkml@lievin.net \
--cc=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
--cc=marcelo.tosatti@cyclades.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox