From: Russell King <rmk+lkml@arm.linux.org.uk>
To: Martin Schwidefsky <schwidefsky@de.ibm.com>
Cc: linux-390@vm.marist.edu,
Linux Kernel List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] Clean up asm/pgalloc.h include (s390)
Date: Mon, 19 Apr 2004 17:11:22 +0100 [thread overview]
Message-ID: <20040419171122.D29446@flint.arm.linux.org.uk> (raw)
In-Reply-To: <OF97AEF891.DC06EC8E-ONC1256E7B.00576CE3-C1256E7B.00578DF9@de.ibm.com>; from schwidefsky@de.ibm.com on Mon, Apr 19, 2004 at 05:56:19PM +0200
On Mon, Apr 19, 2004 at 05:56:19PM +0200, Martin Schwidefsky wrote:
> > This patch cleans up needless includes of asm/pgalloc.h from the
> > arch/s390/ subtree. This has not been compile tested, so
> > needs the architecture maintainers (or willing volunteers) to
> > test.
>
> Doesn't compile. s390_ksyms needs pgalloc.h for the definition of diag10.
> The other includes of pgalloc.h can be removed without a problem.
Alternatively, could the diag10() prototype be moved somewhere else
(tlbflush or cacheflush?) Is diag10 a tlb or cache function? It
isn't clear from the code what diag10() does.
--
Russell King
Linux kernel 2.6 ARM Linux - http://www.arm.linux.org.uk/
maintainer of: 2.6 PCMCIA - http://pcmcia.arm.linux.org.uk/
2.6 Serial core
next prev parent reply other threads:[~2004-04-19 16:11 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-04-19 15:56 [PATCH] Clean up asm/pgalloc.h include (s390) Martin Schwidefsky
2004-04-19 16:11 ` Russell King [this message]
2004-04-20 16:53 ` Arnd Bergmann
-- strict thread matches above, loose matches on Subject: below --
2004-04-18 22:17 [PATCH 1/2] Clean up asm/pgalloc.h include Russell King
2004-04-18 22:23 ` [PATCH 2/2] " Russell King
2004-04-19 13:22 ` [PATCH] Clean up asm/pgalloc.h include (s390) Russell King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040419171122.D29446@flint.arm.linux.org.uk \
--to=rmk+lkml@arm.linux.org.uk \
--cc=linux-390@vm.marist.edu \
--cc=linux-kernel@vger.kernel.org \
--cc=schwidefsky@de.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox