From: Chris Wright <chrisw@osdl.org>
To: Andrea Arcangeli <andrea@suse.de>
Cc: Chris Wright <chrisw@osdl.org>, Ken Ashcraft <ken@coverity.com>,
linux-kernel@vger.kernel.org, mc@cs.stanford.edu,
dri-devel@lists.sourceforge.net
Subject: Re: [CHECKER] Probable security holes in 2.6.5
Date: Tue, 20 Apr 2004 18:38:08 -0700 [thread overview]
Message-ID: <20040420183808.J21045@build.pdx.osdl.net> (raw)
In-Reply-To: <20040421013402.GI29954@dualathlon.random>; from andrea@suse.de on Wed, Apr 21, 2004 at 03:34:02AM +0200
* Andrea Arcangeli (andrea@suse.de) wrote:
> On Fri, Apr 16, 2004 at 11:54:06AM -0700, Chris Wright wrote:
> > + if (mc.idx >= dma->buf_count)
> > + return -EINVAL;
> > +
> > i810_dma_dispatch_mc(dev, dma->buflist[mc.idx], mc.used,
> > mc.last_render );
>
> this is wrong, idx is signed, so you've to check for negative values
> too. Credit for noticing this doesn't belong to me though.
Yes, you are right. I thought I had specifically checked and found it
unsigned. Thanks for catching that.
> Could you just in case review the other fixes too for other potential
> errors like this? thanks.
Yes, I'll do a double check.
thanks,
-chris
--
Linux Security Modules http://lsm.immunix.org http://lsm.bkbits.net
next prev parent reply other threads:[~2004-04-21 1:38 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-04-16 17:01 [CHECKER] Probable security holes in 2.6.5 Ken Ashcraft
2004-04-16 18:20 ` Chris Wright
2004-04-16 19:20 ` Jeff Garzik
2004-04-16 22:12 ` Chris Wright
2004-04-19 16:46 ` Jeff Garzik
2004-04-16 18:32 ` Chris Wright
2004-04-16 18:54 ` Chris Wright
2004-04-21 1:34 ` Andrea Arcangeli
2004-04-21 1:38 ` Chris Wright [this message]
2004-04-16 19:19 ` Chris Wright
2004-04-16 19:27 ` Chris Wright
2004-04-17 6:15 ` Rusty Russell
2004-04-16 20:02 ` Chris Wright
2004-04-16 20:23 ` Chris Wright
2004-04-17 0:16 ` Chris Wright
2004-04-17 1:00 ` Chris Wright
2004-04-19 16:27 ` Jeff Garzik
2004-04-19 19:09 ` Chris Wright
2004-04-19 20:38 ` Chris Wright
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040420183808.J21045@build.pdx.osdl.net \
--to=chrisw@osdl.org \
--cc=andrea@suse.de \
--cc=dri-devel@lists.sourceforge.net \
--cc=ken@coverity.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mc@cs.stanford.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox