public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Pavel Machek <pavel@suse.cz>
To: kernel list <linux-kernel@vger.kernel.org>, seife@suse.de
Subject: b44 needs to reclaim its interrupt after swsusp
Date: Wed, 21 Apr 2004 02:02:08 +0200	[thread overview]
Message-ID: <20040421000208.GA3160@elf.ucw.cz> (raw)

Hi!

b44 needs to free/reclaim its interrupt across suspend in order to
work. This patch makes it work, but I'm not quite sure why its
needed. Interrupt is listed as IO-APIC-level in /proc/interupts.

							Pavel

--- clean/drivers/net/b44.c	2004-04-21 01:32:52.000000000 +0200
+++ linux/drivers/net/b44.c	2004-04-21 01:53:18.000000000 +0200
@@ -1251,7 +1251,7 @@
 }
 
 #if 0
-/*static*/ void b44_dump_state(struct b44 *bp)
+void b44_dump_state(struct b44 *bp)
 {
 	u32 val32, val32_2, val32_3, val32_4, val32_5;
 	u16 val16;
@@ -1874,6 +1874,8 @@
 	b44_free_rings(bp);
 
 	spin_unlock_irq(&bp->lock);
+
+	free_irq(dev->irq, dev);
 	return 0;
 }
 
@@ -1887,6 +1889,9 @@
 
 	pci_restore_state(pdev, bp->pci_cfg_state);
 
+	if (request_irq(dev->irq, b44_interrupt, SA_SHIRQ, dev->name, dev))
+		printk("b44: request_irq failed\n");
+
 	spin_lock_irq(&bp->lock);
 
 	b44_init_rings(bp);


-- 
When do you have a heart between your knees?
[Johanka's followup: and *two* hearts?]

             reply	other threads:[~2004-04-21  0:02 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-04-21  0:02 Pavel Machek [this message]
2004-04-22  3:27 ` b44 needs to reclaim its interrupt after swsusp Jeff Garzik
2004-04-22 10:33   ` Pavel Machek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20040421000208.GA3160@elf.ucw.cz \
    --to=pavel@suse.cz \
    --cc=linux-kernel@vger.kernel.org \
    --cc=seife@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox