From: Andi Kleen <ak@muc.de>
To: James Morris <jmorris@redhat.com>
Cc: Andi Kleen <ak@muc.de>,
linux-kernel@vger.kernel.org, vda@port.imtp.ilyichevsk.odessa.ua
Subject: Re: Large inlines in include/linux/skbuff.h
Date: 23 Apr 2004 00:23:26 +0200
Date: Fri, 23 Apr 2004 00:23:26 +0200 [thread overview]
Message-ID: <20040422222326.GA81305@colin2.muc.de> (raw)
In-Reply-To: <Xine.LNX.4.44.0404221114500.22706-100000@thoron.boston.redhat.com>
On Thu, Apr 22, 2004 at 11:15:47AM -0400, James Morris wrote:
> On Thu, 22 Apr 2004, Andi Kleen wrote:
>
> > > How will these changes impact performance? I asked this last time you
> > > posted about inlines and didn't see any response.
> >
> > I don't think it will be an issue. The optimization guidelines
> > of AMD and Intel recommend to move functions that generate
> > more than 30-40 instructions out of line. 100 instructions
> > is certainly enough to amortize the call overhead, and you
> > safe some icache too so it may be even faster.
>
> Of course, but it would be good to see some measurements.
It's useless in this case. networking is dominated by cache misses
and locks and a modern CPU can do hundreds of function calls in a
single cache miss.
-Andi
next prev parent reply other threads:[~2004-04-22 22:23 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1NvJL-1QO-9@gated-at.bofh.it>
[not found] ` <1NAJr-61F-3@gated-at.bofh.it>
2004-04-22 14:59 ` Large inlines in include/linux/skbuff.h Andi Kleen
2004-04-22 15:15 ` James Morris
2004-04-22 15:37 ` Eric Dumazet
[not found] ` <200404221927.34717.vda@port.imtp.ilyichevsk.odessa.ua>
2004-04-22 19:24 ` Eric Dumazet
2004-04-22 22:23 ` Andi Kleen [this message]
2004-04-22 22:25 ` David S. Miller
2004-04-22 22:34 ` Andi Kleen
2004-04-22 22:35 ` David S. Miller
[not found] ` <1NRqX-2GI-15@gated-at.bofh.it>
[not found] ` <1NRqX-2GI-13@gated-at.bofh.it>
2004-04-22 19:51 ` Andi Kleen
2004-04-21 19:26 Denis Vlasenko
2004-04-22 0:47 ` James Morris
[not found] ` <200404221756.46240.vda@port.imtp.ilyichevsk.odessa.ua>
2004-04-22 18:36 ` David S. Miller
[not found] ` <200404222239.34760.vda@port.imtp.ilyichevsk.odessa.ua>
2004-04-22 22:10 ` David S. Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040422222326.GA81305@colin2.muc.de \
--to=ak@muc.de \
--cc=jmorris@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=vda@port.imtp.ilyichevsk.odessa.ua \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox