From: Chris Wright <chrisw@osdl.org>
To: Peter Waechtler <pwaechtler@mac.com>
Cc: Chris Wright <chrisw@osdl.org>, Andrew Morton <akpm@osdl.org>,
linux-kernel@vger.kernel.org, torvalds@osdl.org
Subject: Re: [PATCH] coredump - as root not only if euid switched
Date: Fri, 23 Apr 2004 10:10:25 -0700 [thread overview]
Message-ID: <20040423101025.J21045@build.pdx.osdl.net> (raw)
In-Reply-To: <10159129.1082704563424.JavaMail.pwaechtler@mac.com>; from pwaechtler@mac.com on Fri, Apr 23, 2004 at 09:16:03AM +0200
* Peter Waechtler (pwaechtler@mac.com) wrote:
> On Thursday, April 22, 2004, at 09:53PM, Chris Wright <chrisw@osdl.org> wrote:
> >This patch breaks various ptrace() checks.
>
> Care to share your wisdom? No? Then please don't reply
- current->mm->dumpable = 0;
+ current->mm->dump_as_root = 1;
Changes like that break ptrace authentication checks. Look more closely
at what mm->dumpable is used for, you'll see checks like:
if (!task->mm->dumpable && !capable(CAP_SYS_PTRACE))
goto out;
BTW, putting the patch inline makes it easier to comment directly on the
patch.
thanks,
-chris
--
Linux Security Modules http://lsm.immunix.org http://lsm.bkbits.net
next prev parent reply other threads:[~2004-04-23 17:10 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-04-23 7:16 [PATCH] coredump - as root not only if euid switched Peter Waechtler
2004-04-23 17:10 ` Chris Wright [this message]
2004-04-23 19:05 ` Peter Wächtler
-- strict thread matches above, loose matches on Subject: below --
2004-04-23 15:35 Albert Cahalan
2004-04-23 19:14 ` Peter Wächtler
2004-04-23 17:22 ` Albert Cahalan
2004-04-23 7:46 Peter Waechtler
2004-04-23 7:14 Peter Waechtler
2004-04-22 9:40 Peter Waechtler
2004-04-22 9:56 ` Andrew Morton
2004-04-22 19:43 ` Peter Wächtler
2004-04-22 19:53 ` Chris Wright
2004-04-22 20:05 ` Linus Torvalds
2004-04-22 8:51 Peter Waechtler
2004-04-22 8:55 ` Andrew Morton
2004-04-21 19:20 Peter Wächtler
2004-04-22 1:18 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040423101025.J21045@build.pdx.osdl.net \
--to=chrisw@osdl.org \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pwaechtler@mac.com \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox