Re: SOFTWARE_SUSPEND as a module

Herbert Xu
2004-04-23T12:29:20Z

On Fri, Apr 23, 2004 at 02:21:23PM +0200, Pavel Machek wrote:
>
> > The point of this is to allow inclusion in distribution kernels where
> > block devices are built as modules.
>
> What's the problem with block devices as module? You need to insmod
> before resume?

Exactly.

> If you really ensure userspace is stopped, you should be fine.
>
> *But* kernel is only correct if userspace is "correct", and need for
> all processes stopped is not going to be obvious to users. I'd like
> kernel to be kernel to be okay regardless what stupid stuff happens in
> userspace. (Well, they really should not scribble on disks).

But in this context if user space is not doing the right thing,
you'll lose whatever the kernel does. For example, if user space
writes to any file systems mounted in the suspended image, then
you'll get corruption no matter what the kernel does.

This module is not meant to be loaded directly by users. It's only
meant to be used by system initrd scripts.

> And here's diff between my tree and mainline.. so that you work on
> current sources.

Thanks.
--
Debian GNU/Linux 3.0 is out! ( http://www.debian.org/ )
Email: Herbert Xu ~{PmV>HI~} <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt