From: Greg KH <greg@kroah.com>
To: Dmitry Torokhov <dtor_core@ameritech.net>
Cc: linux-kernel@vger.kernel.org, Simon Kelley <simon@thekelleys.org.uk>
Subject: Re: [OOPS/HACK] atmel_cs and the latest changes in sysfs/symlink.c
Date: Fri, 23 Apr 2004 08:28:31 -0700 [thread overview]
Message-ID: <20040423152830.GA12126@kroah.com> (raw)
In-Reply-To: <200404230142.46792.dtor_core@ameritech.net>
On Fri, Apr 23, 2004 at 01:42:45AM -0500, Dmitry Torokhov wrote:
> The latest change in sysfs/symlink (conversion to use kobject_name instead
> of name fiedld directly) broke atmel_cs driver:
That's because that driver is broken in the first place. Let me repeat:
NEVER DECLARE A STRUCT DEVICE STATICALLY!!!
Your workaround is just that, a workaround for something that is already
broken, please fix it up correctly, and do not paper over the real root
problem...
The fact that it hasn't oopsed before this symlink fix is only a lucky
accident.
thanks,
greg k-h
prev parent reply other threads:[~2004-04-23 15:28 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-04-23 6:42 [OOPS/HACK] atmel_cs and the latest changes in sysfs/symlink.c Dmitry Torokhov
2004-04-23 12:25 ` Marcel Holtmann
2004-04-23 13:02 ` Dmitry Torokhov
2004-04-23 14:26 ` Marcel Holtmann
2004-04-23 16:55 ` Dmitry Torokhov
2004-04-23 17:16 ` Greg KH
2004-04-23 18:50 ` Marcel Holtmann
2004-04-23 19:46 ` Greg KH
2004-04-23 20:35 ` Russell King
2004-04-23 21:02 ` Marcel Holtmann
2004-04-23 15:31 ` Greg KH
2004-04-23 17:19 ` Greg KH
2004-04-23 18:03 ` Greg KH
2004-04-24 6:44 ` Dmitry Torokhov
2004-04-25 2:49 ` Greg KH
2004-04-25 21:48 ` Dmitry Torokhov
2004-05-04 21:04 ` Greg KH
2004-05-05 7:08 ` Dmitry Torokhov
2004-05-07 23:25 ` Greg KH
2004-04-26 10:19 ` Vojtech Pavlik
2004-04-23 19:55 ` Russell King
2004-04-23 20:14 ` Marcel Holtmann
2004-04-23 20:39 ` Russell King
2004-04-25 21:53 ` Dmitry Torokhov
2004-04-25 22:58 ` Russell King
2004-04-26 10:35 ` Marcel Holtmann
2004-04-26 12:32 ` Dmitry Torokhov
2004-04-26 13:09 ` Marcel Holtmann
2004-04-27 5:57 ` Dmitry Torokhov
2004-04-26 12:26 ` Dmitry Torokhov
2004-04-23 15:28 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040423152830.GA12126@kroah.com \
--to=greg@kroah.com \
--cc=dtor_core@ameritech.net \
--cc=linux-kernel@vger.kernel.org \
--cc=simon@thekelleys.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox