From: Jim Radford <radford@indigita.com>
To: Trond Myklebust <trond.myklebust@fys.uio.no>
Cc: linux-kernel@vger.kernel.org
Subject: [PATCH] 2.6.6-rc2 nfs_fsync() breaks "cvs update"
Date: Fri, 23 Apr 2004 14:21:44 -0700 [thread overview]
Message-ID: <20040423212135.GA1780@indigita.com> (raw)
Hi Trond,
This patch keeps the positive return values of nfs_commit_inode() from
leaking out to fsync(). Without this "cvs update" to an nfs dir
breaks.
-Jim
--- linux-2.6/fs/nfs/write.c.orig 2004-04-16 16:22:19.000000000 -0700
+++ linux-2.6/fs/nfs/write.c 2004-04-23 14:04:26.000000000 -0700
@@ -357,8 +357,10 @@
goto out;
}
err = nfs_commit_inode(inode, 0, 0, wb_priority(wbc));
- if (err > 0)
+ if (err > 0) {
wbc->nr_to_write -= err;
+ err = 0;
+ }
out:
clear_bit(BDI_write_congested, &bdi->state);
wake_up_all(&nfs_write_congestion);
next reply other threads:[~2004-04-23 21:21 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-04-23 21:21 Jim Radford [this message]
-- strict thread matches above, loose matches on Subject: below --
2004-04-24 6:57 [PATCH] 2.6.6-rc2 nfs_fsync() breaks "cvs update" FabF
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040423212135.GA1780@indigita.com \
--to=radford@indigita.com \
--cc=linux-kernel@vger.kernel.org \
--cc=trond.myklebust@fys.uio.no \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox