Re: [OOPS/HACK] atmel_cs and the latest changes in sysfs/symlink.c

Russell King
2004-04-23T20:36:11Z

On Fri, Apr 23, 2004 at 10:16:14AM -0700, Greg KH wrote:
> On Fri, Apr 23, 2004 at 11:55:59AM -0500, Dmitry Torokhov wrote:
> > --- 1.11/drivers/net/wireless/atmel_cs.c Thu Feb 5 05:04:40 2004
> > +++ edited/drivers/net/wireless/atmel_cs.c Fri Apr 23 11:43:42 2004
> > @@ -348,17 +348,13 @@
> > { 0, 0, "11WAVE/11WP611AL-E", "atmel_at76c502e%s.bin", "11WAVE WaveBuddy" }
> > };
> >
> > -/* This is strictly temporary, until PCMCIA devices get integrated into the device model. */
> > -static struct device atmel_device = {
> > - .bus_id = "pcmcia",
> > -};
> > -
>
> <snip>
>
> Much nicer (well, in a wierd way at least.) It seems that the pcmcia
> system is intregrated into the driver model. Why not push it down into
> the individual pcmcia drivers so you don't have to do this GetSysDevice
> kind of hack still?

They're actually getting at is the PCI device, or statically allocated
platform device, rather than anything specific to the card.

Obviously this is going to create the silly scenario where people
can attach PCMCIA device attributes to the bridge device, which
provides the wrong API to userspace.

--
Russell King
Linux kernel 2.6 ARM Linux - http://www.arm.linux.org.uk/
maintainer of: 2.6 PCMCIA - http://pcmcia.arm.linux.org.uk/
2.6 Serial core