From: Duncan Sands <baldrick@free.fr>
To: Greg KH <greg@kroah.com>
Cc: linux-usb-devel@lists.sourceforge.net,
linux-kernel@vger.kernel.org, Frederic Detienne <fd@cisco.com>
Subject: Re: [PATCH 1/9] USB usbfs: take a reference to the usb device
Date: Mon, 26 Apr 2004 16:05:17 +0200 [thread overview]
Message-ID: <200404261605.17486.baldrick@free.fr> (raw)
In-Reply-To: <20040423231811.GA10398@kroah.com>
> Nice, I've applied all 9 patches here (with the updated patch 8
> version). Feel free to send me an update for the warning issue you and
> Oliver talked about if you want to.
Hi Greg, thanks for applying the patches. The following patch goes on top.
Hopefully it will make Oliver happy!
Ciao,
Duncan.
Be assertive.
devio.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff -Nru a/drivers/usb/core/devio.c b/drivers/usb/core/devio.c
--- a/drivers/usb/core/devio.c Mon Apr 26 13:48:28 2004
+++ b/drivers/usb/core/devio.c Mon Apr 26 13:48:28 2004
@@ -350,8 +350,8 @@
* all pending I/O requests; 2.6 does that.
*/
- if (ifnum < 8*sizeof(ps->ifclaimed))
- clear_bit(ifnum, &ps->ifclaimed);
+ BUG_ON(ifnum >= 8*sizeof(ps->ifclaimed));
+ clear_bit(ifnum, &ps->ifclaimed);
usb_set_intfdata (intf, NULL);
/* force async requests to complete */
next prev parent reply other threads:[~2004-04-26 14:08 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-04-14 10:29 [PATCH 1/9] USB usbfs: take a reference to the usb device Duncan Sands
2004-04-17 20:17 ` [linux-usb-devel] " Duncan Sands
2004-04-17 20:33 ` Oliver Neukum
2004-04-18 9:35 ` Duncan Sands
2004-04-18 13:57 ` Oliver Neukum
2004-04-18 14:08 ` Duncan Sands
2004-04-18 14:40 ` Alan Stern
2004-04-19 17:25 ` David Brownell
2004-04-23 23:18 ` Greg KH
2004-04-26 14:05 ` Duncan Sands [this message]
2004-04-26 22:14 ` Greg KH
2004-04-27 8:58 ` [linux-usb-devel] " Oliver Neukum
2004-04-30 9:04 ` Duncan Sands
2004-05-01 23:01 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200404261605.17486.baldrick@free.fr \
--to=baldrick@free.fr \
--cc=fd@cisco.com \
--cc=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb-devel@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox