bug in include file!?

bug in include file!?

[csg69]

Dear Linux Kernel Stuff!


I encountered a strange error recently, when I tried to
compile cdrtools-2.00.3 on my system (debian woody 3.0,
kernel 2.6.5, gcc 2.95.4, make 3.79.1).

The bug is in line 217 in /usr/src/linux/include/scsi/scsi.h
gcc says: parse error before u8
(I think everything is OK there)

Finally I solved the problem by changing the value
in cdrtools-2.00.3/DEFAULTS/Defaults.linux

from the original:
DEFINCDIRS=	$(SRCROOT)/include /usr/src/linux/include

to:
DEFINCDIRS=	$(SRCROOT)/include /usr/include


It seems that in /usr/include/scsi/scsi.h everything is OK...


It may be the error of the makefiles or the kernel include files...

Joerg Schilling (schilling@fokus.fraunhofer.de) advised me
to send to you this report.
He thinks this is a bug in kernel include files.


yours sincerely


csg

Re: bug in include file!?

[Bill Davidsen]

csg69@mailbox.hu wrote:
> Dear Linux Kernel Stuff!
> 
> 
> I encountered a strange error recently, when I tried to
> compile cdrtools-2.00.3 on my system (debian woody 3.0,
> kernel 2.6.5, gcc 2.95.4, make 3.79.1).
> 
> The bug is in line 217 in /usr/src/linux/include/scsi/scsi.h
> gcc says: parse error before u8
> (I think everything is OK there)
> 
> Finally I solved the problem by changing the value
> in cdrtools-2.00.3/DEFAULTS/Defaults.linux
> 
> from the original:
> DEFINCDIRS=	$(SRCROOT)/include /usr/src/linux/include
> 
> to:
> DEFINCDIRS=	$(SRCROOT)/include /usr/include
> 
> 
> It seems that in /usr/include/scsi/scsi.h everything is OK...
> 
> 
> It may be the error of the makefiles or the kernel include files...
> 
> Joerg Schilling (schilling@fokus.fraunhofer.de) advised me
> to send to you this report.
> He thinks this is a bug in kernel include files.

I believe he has set this up so that it won't compile correctly unless 
you have a source tree at /usr/src/linux, and then he uses the includes 
there. He has ignored being told this is not the proper way to do things.

It may be an unrelated problem, but I think he regards ever case where 
the kernel people didn't do things for his convenience as a bug, and 
writes his code to cause problems if you don't do it his way.

If you do audio burns it's worth fighting, they use DMA with the ATA: 
interface. For data the last time I used ide-scsi it was working again, 
although it's not the preferred way to operate. YMMV.

-- 
    -bill davidsen (davidsen@tmr.com)
"The secret to procrastination is to put things off until the
  last possible moment - but no longer"  -me

Re: bug in include file!?

[Christoph Hellwig]

On Mon, Apr 26, 2004 at 10:37:10PM +0200, csg69@mailbox.hu wrote:
> Finally I solved the problem by changing the value
> in cdrtools-2.00.3/DEFAULTS/Defaults.linux
> 
> from the original:
> DEFINCDIRS=	$(SRCROOT)/include /usr/src/linux/include
> 
> to:
> DEFINCDIRS=	$(SRCROOT)/include /usr/include
> 
> 
> It seems that in /usr/include/scsi/scsi.h everything is OK...
> 
> 
> It may be the error of the makefiles or the kernel include files...
> 
> Joerg Schilling (schilling@fokus.fraunhofer.de) advised me
> to send to you this report.
> He thinks this is a bug in kernel include files.

It's a bug in his package actually - userspace programs should not
use kernel headers.  Your change to the makefile is the correct fix.