public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <greg@kroah.com>
To: Duncan Sands <baldrick@free.fr>
Cc: linux-usb-devel@lists.sourceforge.net,
	linux-kernel@vger.kernel.org, Frederic Detienne <fd@cisco.com>
Subject: Re: [PATCH 1/9] USB usbfs: take a reference to the usb device
Date: Mon, 26 Apr 2004 15:14:07 -0700	[thread overview]
Message-ID: <20040426221407.GB22719@kroah.com> (raw)
In-Reply-To: <200404261605.17486.baldrick@free.fr>

On Mon, Apr 26, 2004 at 04:05:17PM +0200, Duncan Sands wrote:
> diff -Nru a/drivers/usb/core/devio.c b/drivers/usb/core/devio.c
> --- a/drivers/usb/core/devio.c	Mon Apr 26 13:48:28 2004
> +++ b/drivers/usb/core/devio.c	Mon Apr 26 13:48:28 2004
> @@ -350,8 +350,8 @@
>  	 * all pending I/O requests; 2.6 does that.
>  	 */
>  
> -	if (ifnum < 8*sizeof(ps->ifclaimed))
> -		clear_bit(ifnum, &ps->ifclaimed);
> +	BUG_ON(ifnum >= 8*sizeof(ps->ifclaimed));

I've changed that to a WARN_ON().  Yeah, writing over memory is bad, but
oopsing is worse.  Let's be a bit nicer than that.

thanks,

greg k-h

  reply	other threads:[~2004-04-26 23:12 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-04-14 10:29 [PATCH 1/9] USB usbfs: take a reference to the usb device Duncan Sands
2004-04-17 20:17 ` [linux-usb-devel] " Duncan Sands
2004-04-17 20:33   ` Oliver Neukum
2004-04-18  9:35     ` Duncan Sands
2004-04-18 13:57       ` Oliver Neukum
2004-04-18 14:08         ` Duncan Sands
2004-04-18 14:40       ` Alan Stern
2004-04-19 17:25   ` David Brownell
2004-04-23 23:18 ` Greg KH
2004-04-26 14:05   ` Duncan Sands
2004-04-26 22:14     ` Greg KH [this message]
2004-04-27  8:58       ` [linux-usb-devel] " Oliver Neukum
2004-04-30  9:04         ` Duncan Sands
2004-05-01 23:01           ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20040426221407.GB22719@kroah.com \
    --to=greg@kroah.com \
    --cc=baldrick@free.fr \
    --cc=fd@cisco.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb-devel@lists.sourceforge.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox