From: William Lee Irwin III <wli@holomorphy.com>
To: Rusty Russell <rusty@rustcorp.com.au>
Cc: Joel Schopp <jschopp@austin.ibm.com>,
Anton Blanchard <anton@samba.org>, Andrew Morton <akpm@osdl.org>,
lkml - Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] Fix cpu iterator on empty bitmask
Date: Tue, 27 Apr 2004 17:05:11 -0700 [thread overview]
Message-ID: <20040428000511.GU743@holomorphy.com> (raw)
In-Reply-To: <1083109972.2150.124.camel@bach>
On Wed, Apr 28, 2004 at 09:52:53AM +1000, Rusty Russell wrote:
> Name: Fix cpumask iterator over empty cpu set
> Status: Trivial
> Can't use _ffs() without first checking for zero, and if bits beyond
> NR_CPUS set it'll give bogus results. Use find_first_bit
I sent in something equivalent to this along with a number of other
fixes (cpus_shift_right() leaking junk bits in in and cpus_weight()
and cpus_empty() and cpus_equal() and the like not ignoring tails) and
got a NAK since it clashes with something Paul Jackson's doing.
-- wli
next prev parent reply other threads:[~2004-04-28 0:10 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-04-27 23:52 [PATCH] Fix cpu iterator on empty bitmask Rusty Russell
2004-04-28 0:05 ` William Lee Irwin III [this message]
2004-04-28 1:22 ` Rusty Russell
2004-04-28 1:31 ` Paul Jackson
2004-04-28 1:57 ` William Lee Irwin III
2004-04-28 2:18 ` Paul Jackson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040428000511.GU743@holomorphy.com \
--to=wli@holomorphy.com \
--cc=akpm@osdl.org \
--cc=anton@samba.org \
--cc=jschopp@austin.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rusty@rustcorp.com.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox