From: Andrew Morton <akpm@osdl.org>
To: Christoph Hellwig <hch@infradead.org>
Cc: trond.myklebust@fys.uio.no, sgoel01@yahoo.com,
linux-kernel@vger.kernel.org
Subject: Re: 2.6.6-rc{1,2} bad VM/NFS interaction in case of dirty page writeback
Date: Wed, 28 Apr 2004 12:07:15 -0700 [thread overview]
Message-ID: <20040428120715.68bc51dd.akpm@osdl.org> (raw)
In-Reply-To: <20040428173811.A1505@infradead.org>
Christoph Hellwig <hch@infradead.org> wrote:
>
> I'm not yet sure where I'm heading with revamping xfs_aops.c, but what
> I'd love to see in the end is more or less xfs implementing only
> writepages and some generic implement writepage as writepages wrapper.
That might make sense. One problem is that writepage expects to be passed
a locked page whereas writepages() does not.
Any code which implements writearound-inside-writepage should be targetted
at a generic implementation, not an fs-specific one if poss. We could go
look at the ->vm_writeback() a_op which was in in 2.5.20 or thereabouts.
it was causing problems and had no discernable benefits so I ripped it out.
A writearound-within-writepage implementation would need to decide whether
it's goign to use lock_page() or TryLockPage(). I expect lock_page() will
be OK - we only call in there for __GFP_FS allocators.
next prev parent reply other threads:[~2004-04-28 20:00 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-04-27 1:12 2.6.6-rc{1,2} bad VM/NFS interaction in case of dirty page writeback Shantanu Goel
2004-04-27 2:15 ` Andrew Morton
2004-04-27 3:11 ` Trond Myklebust
2004-04-27 3:59 ` Andrew Morton
2004-04-27 5:23 ` Trond Myklebust
2004-04-27 5:58 ` Andrew Morton
2004-04-27 11:44 ` Shantanu Goel
2004-04-27 15:36 ` Trond Myklebust
2004-04-28 0:47 ` Shantanu Goel
2004-04-28 1:02 ` Andrew Morton
2004-04-28 1:28 ` Trond Myklebust
2004-04-28 1:38 ` Andrew Morton
2004-04-28 5:29 ` Christoph Hellwig
2004-04-28 16:17 ` Trond Myklebust
2004-04-28 16:38 ` Christoph Hellwig
2004-04-28 19:07 ` Andrew Morton [this message]
2004-04-29 1:48 ` Nathan Scott
2004-04-29 8:27 ` Christoph Hellwig
2004-04-27 6:10 ` Nick Piggin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040428120715.68bc51dd.akpm@osdl.org \
--to=akpm@osdl.org \
--cc=hch@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sgoel01@yahoo.com \
--cc=trond.myklebust@fys.uio.no \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox