Problem with CONFIG_USB_SL811HS

Problem with CONFIG_USB_SL811HS

[Marco Cavallini]

Hello,
I am facing to a problem using linux-2.4.25-vrs2 and/or 2.4.26-vrs1 (ARM
porting).
I think this problem come from the linux kernel and not from ARM patch.
Seems that there is a problem building SL811 USB hosts because if I enable
CONFIG_USB_SL811HS option
the driver seems to be not build and is not running.
I don't know how to manage drivers/usb/host/Makefile for  O_TARGET := in
this case.
Could someone suggest me what to do ?
TIA
Marco Cavallini

# drivers/usb/host/Makefile
# Makefile for USB Host Controller Driver
# framework and drivers
#

O_TARGET :=

obj-$(CONFIG_USB_EHCI_HCD)   += ehci-hcd.o
obj-$(CONFIG_USB_UHCI_ALT)   += uhci.o
obj-$(CONFIG_USB_UHCI)    += usb-uhci.o
obj-$(CONFIG_USB_OHCI)    += usb-ohci.o usb-ohci-pci.o
obj-$(CONFIG_USB_SL811HS_ALT)     += sl811.o
obj-$(CONFIG_USB_SL811HS)     += hc_sl811.o
obj-$(CONFIG_USB_OHCI_SA1111)   += usb-ohci.o usb-ohci-sa1111.o
obj-$(CONFIG_USB_OHCI_AT91)   += usb-ohci.o

# Extract lists of the multi-part drivers.
# The 'int-*' lists are the intermediate files used to build the multi's.
multi-y  := $(filter $(list-multi), $(obj-y))
multi-m  := $(filter $(list-multi), $(obj-m))
int-y  := $(sort $(foreach m, $(multi-y), $($(basename $(m))-objs)))
int-m  := $(sort $(foreach m, $(multi-m), $($(basename $(m))-objs)))

# Take multi-part drivers out of obj-y and put components in.
obj-y  := $(filter-out $(list-multi), $(obj-y)) $(int-y)

# Translate to Rules.make lists.
OX_OBJS  := $(obj-y)
MX_OBJS  := $(obj-m)
MIX_OBJS := $(int-m)

include $(TOPDIR)/Rules.make

Re: Problem with CONFIG_USB_SL811HS

[Greg KH]

On Mon, Apr 26, 2004 at 01:33:45PM +0200, Marco Cavallini wrote:
> Hello,
> I am facing to a problem using linux-2.4.25-vrs2 and/or 2.4.26-vrs1 (ARM
> porting).
> I think this problem come from the linux kernel and not from ARM patch.
> Seems that there is a problem building SL811 USB hosts because if I enable
> CONFIG_USB_SL811HS option
> the driver seems to be not build and is not running.

What is the build errors you get when trying to build this driver?

thanks,

greg k-h

Re: Problem with CONFIG_USB_SL811HS

[Marco Cavallini]

> > I am facing to a problem using linux-2.4.25-vrs2 and/or 2.4.26-vrs1 (ARM
> > porting).
> > I think this problem come from the linux kernel and not from ARM patch.
> > Seems that there is a problem building SL811 USB hosts because if I
enable
> > CONFIG_USB_SL811HS option
> > the driver seems to be not build and is not running.
>
> What is the build errors you get when trying to build this driver?
>

There is no file.o in drivers/usb/host
and there is no SL811 host in the kernel,
the hc_sl811 is not build although I enable CONFIG_USB_SL811HS option.
TIA

Marco Cavallini

Re: Problem with CONFIG_USB_SL811HS

[Sam Ravnborg]

On Tue, Apr 27, 2004 at 08:51:09AM +0200, Marco Cavallini wrote:
> > > I am facing to a problem using linux-2.4.25-vrs2 and/or 2.4.26-vrs1 (ARM
> > > porting).
> > > I think this problem come from the linux kernel and not from ARM patch.
> > > Seems that there is a problem building SL811 USB hosts because if I
> enable
> > > CONFIG_USB_SL811HS option
> > > the driver seems to be not build and is not running.
> >
> > What is the build errors you get when trying to build this driver?
> >
> 
> There is no file.o in drivers/usb/host
> and there is no SL811 host in the kernel,
> the hc_sl811 is not build although I enable CONFIG_USB_SL811HS option.

Did you enable this option using menuconfig?
Please grep for this option in your .config. If it is listed here,
and hc_sl811 is not built then there is a bug in the build system.
But this is so basic so the eror is probarly somewhere else.

	Sam

Re: Problem with CONFIG_USB_SL811HS

[Marco Cavallini]

In Linux-2.4.26 the problem is in 
drivers/usb/host/Makefile

After this block....
subdir-$(CONFIG_USB_OHCI_AT91) += host
ifeq ($(CONFIG_USB_OHCI_AT91),y)
 obj-y += host/usb-ohci.o
endif

...I added this...
######## Begin new code MCK ##########
subdir-$(CONFIG_USB_SL811HS) += host
ifeq ($(CONFIG_USB_SL811HS),y)
 obj-y += host/hc_sl811.o
endif
subdir-$(CONFIG_USB_SL811HS_ALT) += host
ifeq ($(CONFIG_USB_SL811HS_ALT),y)
 obj-y += host/sl811.o
endif
######## End new code MCK ##########

There are also minor modifications, but I'm still working on this driver.
Marco Cavallini
==============================================
Koan s.a.s. - Software Engineering  (x86 and ARM)
Linux solutions for Embedded and Real-Time Software
  - Intel PCA Developer Network member
Via Pascoli, 3  - 24121 Bergamo - ITALIA
Tel./Fax (++39) +35 - 255.235 - www.koansoftware.com
==============================================

Re: Problem with CONFIG_USB_SL811HS

[Marco Cavallini]

In Linux-2.4.26 the problem is in 
drivers/usb/host/Makefile

After this block....
subdir-$(CONFIG_USB_OHCI_AT91) += host
ifeq ($(CONFIG_USB_OHCI_AT91),y)
 obj-y += host/usb-ohci.o
endif

...I added this...
######## Begin new code MCK ##########
subdir-$(CONFIG_USB_SL811HS) += host
ifeq ($(CONFIG_USB_SL811HS),y)
 obj-y += host/hc_sl811.o
endif
subdir-$(CONFIG_USB_SL811HS_ALT) += host
ifeq ($(CONFIG_USB_SL811HS_ALT),y)
 obj-y += host/sl811.o
endif
######## End new code MCK ##########

There are also minor modifications, but I'm still working on this driver.
Marco Cavallini
==============================================
Koan s.a.s. - Software Engineering  (x86 and ARM)
Linux solutions for Embedded and Real-Time Software
  - Intel PCA Developer Network member
Via Pascoli, 3  - 24121 Bergamo - ITALIA
Tel./Fax (++39) +35 - 255.235 - www.koansoftware.com
==============================================

Re: Problem with CONFIG_USB_SL811HS

[Sam Ravnborg]

On Tue, Apr 27, 2004 at 07:36:06PM +0200, Marco Cavallini wrote:
> In Linux-2.4.26 the problem is in 
> drivers/usb/host/Makefile

I assumed you were using the 2.6 kernel, so I did not
even look at 2.4.

Sorry for the noise.

	Sam

Re: Problem with CONFIG_USB_SL811HS

[Marco Cavallini]

> > In Linux-2.4.26 the problem is in
> > drivers/usb/host/Makefile
>
> I assumed you were using the 2.6 kernel, so I did not
> even look at 2.4.
>
> Sorry for the noise.

No problem .
However I've noticed that the latest sources version for SL811 are in 2.4.26
and in 2.6.6 there are only the old one.
Could some linux-usb mantainer tell me if should be a good idea to update
these bringing sources from 2.4.26 and porting them to 2.6.6-rc2 ?
Thank you

Marco Cavallini

Re: Problem with CONFIG_USB_SL811HS

[Greg KH]

On Wed, Apr 28, 2004 at 08:30:40AM +0200, Marco Cavallini wrote:
> Could some linux-usb mantainer tell me if should be a good idea to update
> these bringing sources from 2.4.26 and porting them to 2.6.6-rc2 ?

Yes it is a good idea, I'd gladly take such a patch.

thanks,

greg k-h