public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <greg@kroah.com>
To: Michael_E_Brown@Dell.com
Cc: akpm@osdl.org, linux-kernel@vger.kernel.org, Matt_Domsch@Dell.com
Subject: Re: [BK PATCH] add SMBIOS tables to sysfs
Date: Wed, 28 Apr 2004 10:36:44 -0700	[thread overview]
Message-ID: <20040428173643.GF32040@kroah.com> (raw)
In-Reply-To: <0960978B185D2848BF5BBAE1BFB343E104E3EC@ausx2kmps315.aus.amer.dell.com>

On Wed, Apr 28, 2004 at 12:18:21PM -0500, Michael_E_Brown@Dell.com wrote:
> > -----Original Message-----
> > From: Greg KH [mailto:greg@kroah.com] 
> > 
> > Ok, here are 2 patches.  The first small one is on top of your latest
> > version.  It gets rid of the extra subdirectory, and removes the
> > unneeded kobject from your static structure (NEVER USE A KOBJECT IN A
> > STATIC STRUCTURE!!!!)
> 
> Ok, thanks for the guidance here. I was not aware of this limitation. 

{sigh} I think I need to update the documentation...

> > The secone one is against a clean 2.6.6-rc3 kernel that has 
> > your latest
> > version + my changes.
> > 
> > If you approve of my changes, I'd be glad to add the driver to my bk
> > trees to have it show up in the next -mm release, and I will 
> > push it off
> > to Linus after 2.6.6 is out.  Sound ok?
> 
> This looks good. I'll do a quick compile/boot check. I would really 
> appreciate your help in getting this in. (although I was hoping to get
> it into 2.6.6, I guess it can wait for 2.6.7 :-)

Yes, 2.6.6 is too late, sorry.

Let me know if the patch works for you and then I'll add it to my trees.
It worked for me on my box :)

thanks,

greg k-h

  reply	other threads:[~2004-04-28 19:14 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-04-28 17:18 [BK PATCH] add SMBIOS tables to sysfs Michael_E_Brown
2004-04-28 17:36 ` Greg KH [this message]
  -- strict thread matches above, loose matches on Subject: below --
2004-04-28 17:37 Michael_E_Brown
2004-04-28 17:44 ` Greg KH
2004-04-28  2:27 Michael Brown
2004-04-28  3:30 ` Greg KH
2004-04-28  3:38   ` Michael Brown
2004-04-28 16:50     ` Greg KH
2004-04-28  3:55   ` Michael Brown
2004-04-28 16:51     ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20040428173643.GF32040@kroah.com \
    --to=greg@kroah.com \
    --cc=Matt_Domsch@Dell.com \
    --cc=Michael_E_Brown@Dell.com \
    --cc=akpm@osdl.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox