public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Andrew Morton <akpm@osdl.org>
To: busterbcook@yahoo.com
Cc: linux-kernel@vger.kernel.org
Subject: Re: pdflush eating a lot of CPU on heavy NFS I/O
Date: Wed, 28 Apr 2004 21:02:14 -0700	[thread overview]
Message-ID: <20040428210214.31efe911.akpm@osdl.org> (raw)
In-Reply-To: <Pine.LNX.4.58.0404282244280.13311@ozma.hauschen>

Brent Cook <busterbcook@yahoo.com> wrote:
>
> sync_sb_inodes: write inode c55d25bc
>  __sync_single_inode: writepages in nr_pages:25 nr_to_write:949
>  pages_skipped:0 en:0
>  __sync_single_inode: writepages in nr_pages:25 nr_to_write:949
>  pages_skipped:0 en:0

uh-huh.

Does this fix it?

 25-akpm/fs/fs-writeback.c |    2 +-
 1 files changed, 1 insertion(+), 1 deletion(-)

diff -puN fs/fs-writeback.c~a fs/fs-writeback.c
--- 25/fs/fs-writeback.c~a	2004-04-28 21:01:37.012603336 -0700
+++ 25-akpm/fs/fs-writeback.c	2004-04-28 21:02:00.701002152 -0700
@@ -191,8 +191,8 @@ __sync_single_inode(struct inode *inode,
 				 */
 				inode->i_state |= I_DIRTY_PAGES;
 				inode->dirtied_when = jiffies;
-				list_move(&inode->i_list, &sb->s_dirty);
 			}
+			list_move(&inode->i_list, &sb->s_dirty);
 		} else if (inode->i_state & I_DIRTY) {
 			/*
 			 * Someone redirtied the inode while were writing back

_


  reply	other threads:[~2004-04-29  4:04 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-04-28  5:18 pdflush eating a lot of CPU on heavy NFS I/O Brent Cook
2004-04-28  6:02 ` Andrew Morton
2004-04-28  7:29   ` Phy Prabab
2004-04-28 10:18   ` Sven Geggus
2004-04-28 13:50   ` Brent Cook
2004-04-28 19:48     ` Andrew Morton
2004-04-28 20:12       ` Brent Cook
2004-04-28 20:39       ` Brent Cook
2004-04-28 21:19         ` Trond Myklebust
2004-04-29  3:55           ` Brent Cook
2004-04-29  4:21             ` Trond Myklebust
2004-04-29  4:42               ` Andrew Morton
2004-04-29  1:24         ` Andrew Morton
2004-04-29  3:53           ` Brent Cook
2004-04-29  4:02             ` Andrew Morton [this message]
2004-04-29  4:03               ` Andrew Morton
2004-04-29  4:37               ` Brent Cook
2004-04-29  4:47                 ` Andrew Morton
2004-04-29  5:29                   ` Andrew Morton
2004-04-29 13:19                   ` Brent Cook
2004-04-29  3:54         ` Andrew Morton
2004-04-28  6:06 ` Brett E.

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20040428210214.31efe911.akpm@osdl.org \
    --to=akpm@osdl.org \
    --cc=busterbcook@yahoo.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox