From: Tim Hockin <thockin@sun.com>
To: Linux Kernel mailing list <linux-kernel@vger.kernel.org>
Subject: BUG: might_sleep in /proc/swaps code
Date: Wed, 28 Apr 2004 16:24:58 -0700 [thread overview]
Message-ID: <20040428232457.GB1483@sun.com> (raw)
Testing some othe rwork, totally unrelated, we added a might_sleep() to
mntput(). It turned up this:
Debug: sleeping function called from invalid context at
include/linux/mount.h:82
in_atomic():1, irqs_disabled():0
Call Trace:
[<c012378f>] __might_sleep+0xab/0xcb
[<c018787c>] d_path+0x171/0x272
[<c018ff50>] seq_path+0x4b/0xf4
[<c0165b12>] swap_show+0x3d/0x110
[<c018f87d>] seq_read+0xa8/0x31b
[<c015aa83>] do_brk+0x14f/0x21c
[<c0168fae>] vfs_read+0xaf/0x119
[<c0169224>] sys_read+0x3f/0x5d
[<c010b4e1>] sysenter_past_esp+0x52/0x71
* /proc/swaps uses seq_file code, calling seq_path() with swaplock held
* seq_path() calls d_path()
* d_path() calls mntput() which might_sleep()
Is this worth trying to solve?
--
Tim Hockin
Sun Microsystems, Linux Software Engineering
thockin@sun.com
All opinions are my own, not Sun's
next reply other threads:[~2004-04-29 0:28 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-04-28 23:24 Tim Hockin [this message]
2004-04-29 0:53 ` BUG: might_sleep in /proc/swaps code viro
2004-04-29 2:03 ` viro
2004-04-29 19:22 ` Tim Hockin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040428232457.GB1483@sun.com \
--to=thockin@sun.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox