From: Dmitry Torokhov <dtor_core@ameritech.net>
To: linux-kernel@vger.kernel.org
Cc: Pavel Machek <pavel@suse.cz>, vojtech@suse.cz
Subject: Re: locking in psmouse
Date: Wed, 28 Apr 2004 23:47:46 -0500 [thread overview]
Message-ID: <200404282347.47411.dtor_core@ameritech.net> (raw)
In-Reply-To: <20040428213040.GA954@elf.ucw.cz>
On Wednesday 28 April 2004 04:30 pm, Pavel Machek wrote:
> Hi!
>
> psmouse-base.c does not have any locking. For example psmouse_command
> could race with data coming from the mouse, resulting in problem. This
> should fix it.
> Pavel
Although I am not arguing that locking might be needed in psmouse module I
am somewhat confused how it will help in case of data stream coming from the
mouse... If mouse sent a byte before the kernel issue a command then it will
be delivered by KBC controller and will be processed by the interrupt handler,
probably messing up detection process. That's why as soon as we decide that
the device behind PS/2 port is some kind of mouse we disable the stream mode.
--
Dmitry
next prev parent reply other threads:[~2004-04-29 4:47 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-04-28 21:30 locking in psmouse Pavel Machek
2004-04-29 4:47 ` Dmitry Torokhov [this message]
2004-04-29 9:58 ` Pavel Machek
2004-04-29 12:40 ` Dmitry Torokhov
2004-04-29 19:43 ` Pavel Machek
2004-06-06 17:41 ` Vojtech Pavlik
2004-06-06 18:51 ` Pavel Machek
2004-06-06 19:34 ` Vojtech Pavlik
2004-04-29 16:02 ` Vojtech Pavlik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200404282347.47411.dtor_core@ameritech.net \
--to=dtor_core@ameritech.net \
--cc=linux-kernel@vger.kernel.org \
--cc=pavel@suse.cz \
--cc=vojtech@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox