From: Andrew Morton <akpm@osdl.org>
To: Keith Owens <kaos@sgi.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [patch] 2.6.6-rc3 Allow architectures to reenable interrupts on contended spinlocks
Date: Fri, 30 Apr 2004 00:07:51 -0700 [thread overview]
Message-ID: <20040430000751.6703e950.akpm@osdl.org> (raw)
In-Reply-To: <7094.1083122965@kao2.melbourne.sgi.com>
Keith Owens <kaos@sgi.com> wrote:
>
> As requested by Linus, update all architectures to add the common
> infrastructure. Tested on ia64 and i386.
>
>
> Enable interrupts while waiting for a disabled spinlock, but only if
> interrupts were enabled before issuing spin_lock_irqsave().
Please test stuff with CONFIG_SMP=n?
include/linux/sched.h: In function `dequeue_signal_lock':
include/linux/sched.h:795: warning: implicit declaration of function `_raw_spin_lock_flags'
--- 25/include/linux/spinlock.h~allow-architectures-to-reenable-interrupts-on-contended-spinlocks-fix 2004-04-29 23:53:48.357203736 -0700
+++ 25-akpm/include/linux/spinlock.h 2004-04-29 23:54:15.053145336 -0700
@@ -46,6 +46,8 @@
#else
+#define _raw_spin_lock_flags(lock, flags) _raw_spin_lock(lock)
+
#if !defined(CONFIG_PREEMPT) && !defined(CONFIG_DEBUG_SPINLOCK)
# define atomic_dec_and_lock(atomic,lock) atomic_dec_and_test(atomic)
# define ATOMIC_DEC_AND_LOCK
_
The feature is only enabled for spin_lock_irqsave(). Should it not also do
something about spin_lock_irq()?
prev parent reply other threads:[~2004-04-30 7:08 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-04-27 1:59 [patch] 2.6.6-rc2 Allow architectures to reenable interrupts on contended spinlocks Keith Owens
2004-04-27 4:49 ` Andrew Morton
2004-04-27 5:19 ` Keith Owens
2004-04-27 6:54 ` Benjamin Herrenschmidt
2004-04-27 7:45 ` Keith Owens
2004-04-27 11:36 ` Paul Mackerras
2004-04-27 12:05 ` Keith Owens
2004-04-27 12:33 ` Christoph Hellwig
2004-04-27 16:01 ` Linus Torvalds
2004-04-28 3:29 ` [patch] 2.6.6-rc3 " Keith Owens
2004-04-30 7:07 ` Andrew Morton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040430000751.6703e950.akpm@osdl.org \
--to=akpm@osdl.org \
--cc=kaos@sgi.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox