From: Jens Axboe <axboe@suse.de>
To: Matt Domsch <Matt_Domsch@dell.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: reduce blk queue and I/O capability printk to KERN_DEBUG?
Date: Fri, 30 Apr 2004 23:13:43 +0200 [thread overview]
Message-ID: <20040430211342.GA31842@suse.de> (raw)
In-Reply-To: <20040430195055.GA7235@lists.us.dell.com>
On Fri, Apr 30 2004, Matt Domsch wrote:
> Jens,
>
> Any reason why this message isn't being printed at KERN_DEBUG or
> thereabouts, as the comment immediately before it notes it's for
> debugging purposes, and it's only interesting to kernel developers not
> end users?
>
> Thanks,
> Matt
>
> --
> Matt Domsch
> Sr. Software Engineer, Lead Engineer
> Dell Linux Solutions linux.dell.com & www.dell.com/linux
> Linux on Dell mailing lists @ http://lists.us.dell.com
>
> ===== drivers/block/ll_rw_blk.c 1.244 vs edited =====
> --- 1.244/drivers/block/ll_rw_blk.c Tue Apr 27 08:11:32 2004
> +++ edited/drivers/block/ll_rw_blk.c Fri Apr 30 14:46:57 2004
> @@ -284,7 +284,7 @@
> * keep this for debugging for now...
> */
> if (dma_addr != BLK_BOUNCE_HIGH && q != last_q) {
> - printk("blk: queue %p, ", q);
> + printk(KERN_DEBUG "blk: queue %p, ", q);
> if (dma_addr == BLK_BOUNCE_ANY)
> printk("no I/O memory limit\n");
> else
It should just be deleted. As you note, it is a debug message. I
originally added it so we would have some clues as to dma capability for
bug reports. There never was any, the check can go :)
--
Jens Axboe
next prev parent reply other threads:[~2004-04-30 21:21 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-04-30 19:50 reduce blk queue and I/O capability printk to KERN_DEBUG? Matt Domsch
2004-04-30 21:13 ` Jens Axboe [this message]
2004-04-30 21:28 ` Matt Domsch
2004-04-30 21:44 ` Matt Domsch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040430211342.GA31842@suse.de \
--to=axboe@suse.de \
--cc=Matt_Domsch@dell.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox