From: Greg KH <greg@kroah.com>
To: stefan.eletzhofer@eletztrick.de, linux-kernel@vger.kernel.org,
Andrew Morton <akpm@osdl.org>
Subject: Re: [PATCH] 2.6 I2C epson 8564 RTC chip
Date: Sat, 1 May 2004 22:51:44 -0700 [thread overview]
Message-ID: <20040502055144.GE31886@kroah.com> (raw)
In-Reply-To: <20040501092604.GA23561@gonzo.local>
On Sat, May 01, 2004 at 11:26:04AM +0200, stefan.eletzhofer@eletztrick.de wrote:
> On Fri, Apr 30, 2004 at 10:48:04PM -0700, Greg KH wrote:
> > On Thu, Apr 29, 2004 at 02:02:50PM +0200, stefan.eletzhofer@eletztrick.de wrote:
> > > + if ( !buf || !client ) {
> >
> > Can you clean up your exuberant use of spaces in 'if' statements, and
> > function calls? It's not the proper kernel style.
> >
> > > +DONE:
> >
> > Lowercase please
> >
> > > + if ( ret ) {
> > > + if ( d ) kfree( d );
> >
> > No need to check a pointer before sending it to kfree.
>
> Ok, that should be it. I've also ran the source through Lindent,
> which fixed some further things. I've reverted the indention change
> for labels, though. I think labels should be at level zero, should
> they?
Looks good, applied, thanks.
greg k-h
prev parent reply other threads:[~2004-05-02 6:21 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-04-29 12:02 [PATCH] 2.6 I2C epson 8564 RTC chip stefan.eletzhofer
2004-04-29 12:41 ` Ian Campbell
2004-04-29 12:54 ` Russell King
2004-04-29 13:58 ` stefan.eletzhofer
2004-04-29 14:14 ` Ian Campbell
2004-04-29 14:28 ` stefan.eletzhofer
2004-04-29 22:40 ` Tom Rini
2004-04-29 22:49 ` Russell King
2004-04-29 22:52 ` Tom Rini
2004-04-29 23:07 ` Russell King
2004-04-29 12:59 ` Ian Campbell
2004-04-29 13:55 ` stefan.eletzhofer
2004-05-01 5:48 ` Greg KH
2004-05-01 9:26 ` stefan.eletzhofer
2004-05-02 5:51 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040502055144.GE31886@kroah.com \
--to=greg@kroah.com \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=stefan.eletzhofer@eletztrick.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox